DeliveryComplete missing info

[damajor]

Have you checked closed issues? (https://github.com/Textualize/textual/issues?q=is%3Aissue+is%3Aclosed)

yes

Have you checked against the most recent version of Textual? (https://pypi.org/search/?q=textual)

yes

The bug

I use deliver_binary and catch complete/failed downloads with DeliveryComplete DeliveryFailed events.

But I noticed that DeliveryComplete never returns the name used in the deliver_binary call.

textual diagnose

# Textual Diagnostics

## Versions

| Name    | Value  |
|---------|--------|
| Textual | 3.4.0  |
| Rich    | 14.0.0 |

## Python

| Name           | Value                                  |
|----------------|----------------------------------------|
| Version        | 3.12.10                                |
| Implementation | CPython                                |
| Compiler       | GCC 14.2.1 20240912 (Red Hat 14.2.1-3) |
| Executable     | /usr/bin/python3                       |

## Operating System

| Name    | Value                                               |
|---------|-----------------------------------------------------|
| System  | Linux                                               |
| Release | 6.14.5-100.fc40.x86_64                              |
| Version | #1 SMP PREEMPT_DYNAMIC Fri May  2 14:22:13 UTC 2025 |

## Terminal

| Name                 | Value          |
|----------------------|----------------|
| Terminal Application | *Unknown*      |
| TERM                 | xterm-256color |
| COLORTERM            | truecolor      |
| FORCE_COLOR          | *Not set*      |
| NO_COLOR             | *Not set*      |

## Rich Console options

| Name           | Value                |
|----------------|----------------------|
| size           | width=254, height=57 |
| legacy_windows | False                |
| min_width      | 1                    |
| max_width      | 254                  |
| is_terminal    | True                 |
| encoding       | utf-8                |
| max_height     | 57                   |
| justify        | None                 |
| overflow       | None                 |
| no_wrap        | False                |
| highlight      | None                 |
| markup         | None                 |
| height         | None                 |

[github-actions]

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

[TomJGooding]

DeliveryComplete never returns the name used in the deliver_binary call.

Perhaps I've misunderstood what you mean, but this seems to work from a quick test?

$ touch test
$ textual run repro_5872.py

# repro_5872.py

from pathlib import Path

from textual import on
from textual.app import App
from textual.events import DeliveryComplete


class ExampleApp(App):
    def on_mount(self) -> None:
        self.deliver_binary(
            Path("test"),
            name="deliver-binary-test",
        )

    @on(DeliveryComplete)
    def on_delivery_complete(self, event: DeliveryComplete) -> None:
        self.notify(
            f"{event.name=}",
            title="DeliveryComplete",
        )


if __name__ == "__main__":
    app = ExampleApp()
    app.run()

[damajor]

Cannot reproduce either, maybe that was happening when using textual-serve. But working fine with ganglion.

[github-actions]

I hope I solved your issue!

Consider sponsoring my work to continue to maintain and develop Textual.

• Will McGugan