From 85db1348feceeb3c21ae234585aa6fdf2fc8bfe6 Mon Sep 17 00:00:00 2001 From: Pravhesh V Date: Wed, 24 Sep 2025 20:54:23 +0530 Subject: [PATCH 1/4] test: improve test coverage and fix negative exponents in power_using_recursion.py --- maths/power_using_recursion.py | 74 +++++++++++++++++++--------------- 1 file changed, 42 insertions(+), 32 deletions(-) diff --git a/maths/power_using_recursion.py b/maths/power_using_recursion.py index eb775b161ae8..aef422ae4869 100644 --- a/maths/power_using_recursion.py +++ b/maths/power_using_recursion.py @@ -13,41 +13,43 @@ """ -def power(base: int, exponent: int) -> float: +def power(base: float, exponent: int) -> float: """ - Calculate the power of a base raised to an exponent. + Calculate the power of a base raised to an exponent using recursion. + Args: + base (int): The base number. + exponent (int): The exponent number. + + Returns: + the calculated value of base^exponent || base**exponent + + cases: >>> power(3, 4) 81 >>> power(2, 0) 1 - >>> all(power(base, exponent) == pow(base, exponent) - ... for base in range(-10, 10) for exponent in range(10)) - True - >>> power('a', 1) - 'a' - >>> power('a', 2) - Traceback (most recent call last): - ... - TypeError: can't multiply sequence by non-int of type 'str' - >>> power('a', 'b') - Traceback (most recent call last): - ... - TypeError: unsupported operand type(s) for -: 'str' and 'int' + >>> power(5, 1) + 5 >>> power(2, -1) - Traceback (most recent call last): - ... - RecursionError: maximum recursion depth exceeded - >>> power(0, 0) - 1 - >>> power(0, 1) + 0.5 + >>> power(-2, 3) + -8 + >>> power(-2, 2) + 4 + >>> power(0, 5) 0 - >>> power(5,6) - 15625 - >>> power(23, 12) - 21914624432020321 + >>> power (0,0) + 1 """ - return base * power(base, (exponent - 1)) if exponent else 1 + if not isinstance(exponent, int): + raise TypeError("exponent must be an integer") + + if exponent == 0: + return 1 + if exponent < 0: + return 1 / power(base, -exponent) + return base * power(base, exponent - 1) if __name__ == "__main__": @@ -55,9 +57,17 @@ def power(base: int, exponent: int) -> float: testmod() print("Raise base to the power of exponent using recursion...") - base = int(input("Enter the base: ").strip()) - exponent = int(input("Enter the exponent: ").strip()) - result = power(base, abs(exponent)) - if exponent < 0: # power() does not properly deal w/ negative exponents - result = 1 / result - print(f"{base} to the power of {exponent} is {result}") + try: + base = float(input("Enter the base: ").strip()) + exponent = int(input("Enter the exponent: ").strip()) + result = power(base, exponent) + print(f"{base} to the power of {exponent} is {result}") + except ValueError as e: + print(f"Invalid input: {e} ") + except TypeError as e: + print(f"error: {e}") + except RecursionError: + print( + """error: Maximum recursive depth exceeded. + The exponent you might have given as input might have been very large""" + ) From c2846e388232f07bd5c43b3ff8c243bef3eb714d Mon Sep 17 00:00:00 2001 From: Rxbber-dxcky Date: Thu, 25 Sep 2025 08:30:38 +0530 Subject: [PATCH 2/4] fix: update expected output in matrix_inversion.py doctest --- linear_algebra/matrix_inversion.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linear_algebra/matrix_inversion.py b/linear_algebra/matrix_inversion.py index 50dae1c2e825..5e38c21db6a6 100644 --- a/linear_algebra/matrix_inversion.py +++ b/linear_algebra/matrix_inversion.py @@ -12,7 +12,7 @@ def invert_matrix(matrix: list[list[float]]) -> list[list[float]]: list[list[float]]: Inverted matrix if invertible, else raises error. >>> invert_matrix([[4.0, 7.0], [2.0, 6.0]]) - [[0.6000000000000001, -0.7000000000000001], [-0.2, 0.4]] + [[0.6, -0.7000000000000001], [-0.2, 0.4]] >>> invert_matrix([[1.0, 2.0], [0.0, 0.0]]) Traceback (most recent call last): ... From f330a893fbdc1e40434c54dc6e897a6d31113ce0 Mon Sep 17 00:00:00 2001 From: Rxbber-dxcky Date: Thu, 25 Sep 2025 08:37:10 +0530 Subject: [PATCH 3/4] revert: revert matrix inversion test case to original expected output --- linear_algebra/matrix_inversion.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linear_algebra/matrix_inversion.py b/linear_algebra/matrix_inversion.py index 5e38c21db6a6..50dae1c2e825 100644 --- a/linear_algebra/matrix_inversion.py +++ b/linear_algebra/matrix_inversion.py @@ -12,7 +12,7 @@ def invert_matrix(matrix: list[list[float]]) -> list[list[float]]: list[list[float]]: Inverted matrix if invertible, else raises error. >>> invert_matrix([[4.0, 7.0], [2.0, 6.0]]) - [[0.6, -0.7000000000000001], [-0.2, 0.4]] + [[0.6000000000000001, -0.7000000000000001], [-0.2, 0.4]] >>> invert_matrix([[1.0, 2.0], [0.0, 0.0]]) Traceback (most recent call last): ... From c236a80bc532354f18abcab753113933f60e3635 Mon Sep 17 00:00:00 2001 From: Rxbber-dxcky Date: Thu, 25 Sep 2025 09:12:21 +0530 Subject: [PATCH 4/4] test: use pytest.approx for floating-point comparison in matrix inversion test --- linear_algebra/matrix_inversion.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/linear_algebra/matrix_inversion.py b/linear_algebra/matrix_inversion.py index 50dae1c2e825..edcd943aa718 100644 --- a/linear_algebra/matrix_inversion.py +++ b/linear_algebra/matrix_inversion.py @@ -11,8 +11,12 @@ def invert_matrix(matrix: list[list[float]]) -> list[list[float]]: Returns: list[list[float]]: Inverted matrix if invertible, else raises error. - >>> invert_matrix([[4.0, 7.0], [2.0, 6.0]]) - [[0.6000000000000001, -0.7000000000000001], [-0.2, 0.4]] + >>> from pytest import approx + >>> result = invert_matrix([[4.0, 7.0], [2.0, 6.0]]) + >>> expected = [[0.6000000000000001, -0.7000000000000001], [-0.2, 0.4]] + >>> all (all(approx(x) == y for x, y in zip(row_res, row_exp)) + ... for row_res, row_exp in zip(result, expected)) + True >>> invert_matrix([[1.0, 2.0], [0.0, 0.0]]) Traceback (most recent call last): ...