breakpoint: hit count is double-incremented when both `on_hit` and `should_break_with_context` are called

[Timi16]

File: src/debugger/breakpoint.rs

Both on_hit and should_break_with_context call bp.increment_hit(). If a caller invokes both methods for the same hit event (which is easy given the overlapping APIs), the hit count advances by 2 instead of 1, breaking ==N and %N==0 hit conditions.

Proposal: Consolidate hit counting into a single internal method and deprecate/remove the duplicate entry point.

[Belzabeem]

@Belzabeem has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Can i please work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Belzabeem to this issue.

[drips-wave]

Congratulations, @Belzabeem! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @Belzabeem: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been removed from the Stellar Wave Program by the repository maintainers.

@Belzabeem, you have been unassigned from this issue. If you have any questions, please reach out to the repo maintainers.