Renaming the subsitution group not to be alike with a class (ServiceAccessRight)

[skinkie]

I would like to have a discussion on things that are either abstracts or subsitution groups currently suffixed with "_". This causes code generation to do funky things. Is there any way we could just rename them to something so it becomes clear they are not to be used as element ever? This is at least the case for ServiceAccessRight.

https://github.com/NeTEx-CEN/NeTEx/blob/master/xsd/netex_part_3/part3_fares/netex_fareProduct_version.xsd#L145

Suggestion to take a look at:

assignment_version_structure
bounding_box_structure
empty_type
extensions
extensions_structure
group_of_entities_ref_structure
line_shape_structure
location_structure
point
point_on_link_ref_structure
series_constraint_ref_structure
service_access_right
srs_name
travel_specification

[Aurige]

Objects with a trailing "" like **ServiceAccessRight** should probably be abstract
A trailing "" also mean that they are not to be used as element ever
But all abstract object don't have a "", we could have a convention to add it ... I don't think that this would break anything

[Aurige]

Discussed: Replace he trailing "_" with "_Dummy" ... to be done at the end of the revision process by @skinkie

[skinkie]

There are currently two situations where I think the extra dummy does not make sense. In both cases they were extended to facilitate order. But what was the reason not to add order as an extension, instead of a restriction?

Ok, the reason is that ref get another type.

        <xsd:complexType name="PointOnLinkRefStructure_">
                <xsd:annotation>
                        <xsd:documentation>Type for a reference to a POINT ON LINK.</xsd:documentation>
                </xsd:annotation>
                <xsd:simpleContent>
                        <xsd:extension base="PointRefStructure">
                                <xsd:attribute name="order" type="xsd:positiveInteger" use="optional">
                                        <xsd:annotation>
                                                <xsd:documentation>Order of point on link. -v2.0</xsd:documentation>
                                        </xsd:annotation>
                                </xsd:attribute>
                        </xsd:extension>
                </xsd:simpleContent>
        </xsd:complexType>
        <xsd:complexType name="PointOnLinkRefStructure">
                <xsd:annotation>
                        <xsd:documentation>Type for a reference to a POINT ON LINK.</xsd:documentation>
                </xsd:annotation>
                <xsd:simpleContent>
                        <xsd:restriction base="PointOnLinkRefStructure_">
                                <xsd:attribute name="ref" type="PointOnLinkIdType" use="required">
                                        <xsd:annotation>
                                                <xsd:documentation>Identifier of a LINK.</xsd:documentation>
                                        </xsd:annotation>
                                </xsd:attribute>
                        </xsd:restriction>
                </xsd:simpleContent>
        </xsd:complexType>

        <xsd:complexType name="SeriesConstraintRefStructure_">
                <xsd:annotation>
                        <xsd:documentation>Extending type for Reference to a SERIES CONSTRAINT.</xsd:documentation>
                </xsd:annotation>
                <xsd:simpleContent>
                        <xsd:extension base="PriceableObjectRefStructure"> 
                                <xsd:attribute name="order" type="xsd:positiveInteger" use="optional">
                                        <xsd:annotation>
                                                <xsd:documentation>order of constraint. -v2.0</xsd:documentation>
                                        </xsd:annotation>
                                </xsd:attribute>
                        </xsd:extension>
                </xsd:simpleContent>
        </xsd:complexType>
        <xsd:complexType name="SeriesConstraintRefStructure">
                <xsd:annotation>
                        <xsd:documentation>Type for Reference to a SERIES CONSTRAINT.</xsd:documentation>
                </xsd:annotation>
                <xsd:simpleContent>
                        <xsd:restriction base="SeriesConstraintRefStructure_"> 
                                <xsd:attribute name="ref" type="SeriesConstraintIdType" use="required">
                                        <xsd:annotation>
                                                <xsd:documentation>Identifier of a SERIES CONSTRAINT.</xsd:documentation>
                                        </xsd:annotation>
                                </xsd:attribute> 
                        </xsd:restriction>
                </xsd:simpleContent>
        </xsd:complexType>