Should SingleJourney relate to VehicleTypeRef and not VehicleRef?

[TuThoThai]

NeTEx part 5

I think there is a bug in the XSD of NeTEx Part 5 for SingleJourney:

	<xsd:group name="SingleJourneyReferencesGroup">
		<xsd:annotation>
			<xsd:documentation>Reference Elements for SINGLE JOURNEY. </xsd:documentation>
		</xsd:annotation>
		<xsd:sequence>
			<xsd:element ref="CommonVehicleServiceRef" minOccurs="0"/>
			<xsd:element ref="VehicleRef" minOccurs="0"/>
			<xsd:element ref="SingleJourneyPathRef" minOccurs="0"/>
		</xsd:sequence>
	</xsd:group>

I think, it should read VehicleTyepRef instead of VehicleRef which would translate in:

	<xsd:group name="SingleJourneyReferencesGroup">
		<xsd:annotation>
			<xsd:documentation>Reference Elements for SINGLE JOURNEY. </xsd:documentation>
		</xsd:annotation>
		<xsd:sequence>
			<xsd:element ref="CommonVehicleServiceRef" minOccurs="0"/>
			<xsd:element ref="VehicleTypeRef" minOccurs="0"/>
			<xsd:element ref="SingleJourneyPathRef" minOccurs="0"/>
		</xsd:sequence>
	</xsd:group>

But, because we have decided to freeze the XSD, I can work on the PR for 2.1

[skinkie]

If it is a bug, it should still be fixed in 2.0.

[TuThoThai]

@Aurige and/or @ue71603 : could you confirm if it is a bug? If yes, happy to correct it! 😄

[skinkie]

I do have a question. If it is a single journey and one knows what it is executed with. VehicleRef is correct right?

[TuThoThai]

That is the question I had too. And because I am not so familiar with Part 5, I wasn't sure.
The only hint I had that it might be a bug is that the document refers to Vehicle Type and the XSD was marked as having an error in XMLSpy. 🤔

[ue71603]

that is again a hint, why it was a very bad idea to try to do VehicleType from Vehicle. In a SingleJourney in new modes it is in my view a given VEHICLE.

[ue71603]

And I think bug fixes should go into V2.0.1
I had a look at Transmodel: "The planned movement of any type of vehicle from the start point to the end point of a JOURNEY on a specified route." So, according to the others it is a VEHICLE TYPE. (see how it was not used properly in the definition). I would create an issue for Transmodel, but hey, there is no issue tracker.

[Aurige]

Thinking a little more about it, a SingleJourney is expected to run only once (typically a Car Pooling journey), and therefore can be associated to a physical vehicle... in fact it has to, when you publish the carpooling offer you need to tell what car you will use. Of course you can complement it with a VehicleType (but you can also get it from the Vehicle), but the VehicleRef needs to be available