Upgrade nixpkgs to 20.09, rules_haskell to 0.13, rules_nixpkgs to 0.7 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
commented
Nov 25, 2020
avdv
commented
- remove package override for brittany, this was fixed in nixpkgs
- fix compiler errors due to unused imports
- fix compilation due to API changes in xml-conduit 1.9.0.0
- upgrade GHC to version 8.8.4
Member
|
Thank you for the update! Anything else to add to this PR, since I see it is marked as draft? |
avdv
commented
Dec 2, 2020
| #load("@rules_haskell//haskell:toolchain.bzl", "rules_haskell_toolchains") | ||
|
|
||
| rules_haskell_toolchains(version = "8.6.5") | ||
| #rules_haskell_toolchains(version = "8.8.4") |
Author
There was a problem hiding this comment.
Had to remove those lines, otherwise it would not build... IIRC.
Author
I just wasn't sure about the lines I had to remove.. it's working fine for me. BTW, thank you for this template, it was a tremendous learning resource for me! ❤️ |
avdv
force-pushed
the
upgrade-nix-and-bazel-rules
branch
from
71697b3 to
5053f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.