-
Notifications
You must be signed in to change notification settings - Fork 25
Description
-
ParallelVector uses dynamic_casts to type T even though T is known and can be statically casted
-
class Vector includes SparseMatrix without using it. commented energy norms used this include, but better to outsource this functionality if not already done
-
operations_vec_on_index_set implements methods that seems to be unused
// calculates s += norm_2^2(a)
void VecNormSquaredAdd(const vector_t &a, const vector_t &b, number &sum, const std::vector<size_t> vIndex)
// returns norm_2^2(a)
inline number VecNormSquared(const vector_t &a, const vector_t &b,const std::vector<size_t> vIndex)
parameter b does not appear in calculations?
-
schur_complement_operator implicitly copies the vector in vector_type dskeleton(fskeleton); maybe this should be done explicitly instead to be clear about what happens there
-
define default template arguments for GridFunction, ParallelVector, Vector classes or implement concepts that reveal the functionality that can be expected by the class
-
override virtual_clones instead of just declare these as virtual since this might not fully apply to the vtable
-
const upper loop boundaries for vector implementation to improve autovectorization for the compiler