Skip to content

Conversation

@Yarloy037
Copy link

Description

This PR fixes the event handler syntax in both TypeScript and JavaScript application templates to comply with UI5 best practices and UI5 Linter requirements.

Problem

Generated applications contain event handlers without the required dot prefix:

  • press="sayHello"

This triggers UI5 Linter warning: no-ambiguous-event-handler

Solution

Added dot prefix to all controller method event handlers:

  • press=".sayHello"

Changes

  • Updated resources/template-ts/webapp/view/Main.view.xml
  • Updated resources/template-js/webapp/view/Main.view.xml

References


**Thank you for your contribution!** 🙌

To get it merged faster, kindly review the checklist below:

## Pull Request Checklist
- [ ] Reviewed the [Contributing Guidelines](https://github.com/UI5/mcp-server/blob/main/CONTRIBUTING.md#-contributing-code)
    + Especially the [How to Contribute](https://github.com/UI5/mcp-server/blob/main/CONTRIBUTING.md#how-to-contribute) section 
- [ ] [No merge commits](https://github.com/UI5/mcp-server/blob/main/docs/Guidelines.md#no-merge-commits)
- [ ] [Correct commit message style](https://github.com/UI5/mcp-server/blob/main/docs/Guidelines.md#commit-message-style)

- Add dot prefix to 'sayHello' event handlers in both TS and JS templates
- Fixes UI5 Linter warning: no-ambiguous-event-handler
- Ensures generated apps follow UI5 best practices
@cla-assistant
Copy link

cla-assistant bot commented Dec 1, 2025

CLA assistant check
All committers have signed the CLA.

@Yarloy037 Yarloy037 marked this pull request as draft December 2, 2025 03:31
@Yarloy037 Yarloy037 marked this pull request as ready for review December 2, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant