Skip to content

fix(ObjectPage): use UI5WC tabbar shadow #7975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ObjectPage): use UI5WC tabbar shadow #7975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7fa13b
fix(ObjectPage): use UI5WC tabbar shadow
Lukas742 Nov 24, 2025
86b0339
fix test
Lukas742 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions packages/main/src/components/ObjectPage/ObjectPage.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,21 +105,15 @@
z-index: 4;
}

.tabContainerSpacer {
height: 3px;
background: var(--sapObjectHeader_Background);
}

.tabContainer {
position: sticky;
z-index: 3;
background: var(--sapObjectHeader_Background);
padding-block-start: 3px;
&::after {
content: '';
pointer-events: none;
position: absolute;
height: 1px;
inset-block-end: -1px;
inset-inline-start: 0;
width: 100%;
box-shadow: var(--sapContent_HeaderShadow);
}
}

.tabContainerComponent {
Expand All @@ -130,7 +124,6 @@
&::part(tabstrip) {
padding: 0;
padding-inline: var(--_ui5wcr_ObjectPage_tab_bar_inline_padding);
box-shadow: none;
}
}

Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/components/ObjectPage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,6 +726,8 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
: `${topHeaderHeight}px`,
}}
>
{/* Spacer required to prevent overlapping of tabbar btns and expand/pin btns*/}
<div aria-hidden="true" className={classNames.tabContainerSpacer} />
<TabContainer
collapsed
onTabSelect={handleTabSelect}
Expand Down
6 changes: 3 additions & 3 deletions packages/main/src/components/ObjectPageTitle/ObjectPageTitle.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ describe('ObjectPageTitle', () => {
);
// no nav actions
// The overflow breadcrumbs button requires time until it's mounted -> value can be different initially
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '1793px' /*100%*/);
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '1808px' /*100%*/);
cy.mount(
<PageComponent
titleProps={{
Expand All @@ -93,10 +93,10 @@ describe('ObjectPageTitle', () => {
/>,
);
// nav actions in actions toolbar
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '1793px' /*100%*/);
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '1808px' /*100%*/);
cy.viewport(1000, 1000);
// w/ nav actions
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '452.5px' /*50% (min-width)*/);
cy.findByTestId('breadcrumbs').parent().should('have.css', 'width', '460px' /*50% (min-width)*/);
});

it('expandedContent & snappedContent', () => {
Expand Down