Skip to content

Marking constructors as noexcept when possible #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThibaultDECO wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Marking constructors as noexcept when possible #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79bf6e5
Marking constructors as noexcept
ThibaultDECO Oct 15, 2022
e1d4e2a
Marking constructors as noexcept
ThibaultDECO Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/cereal/archives/binary.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ namespace cereal
//! Construct, outputting to the provided stream
/*! @param stream The stream to output to. Can be a stringstream, a file stream, or
even cout! */
BinaryOutputArchive(std::ostream & stream) :
BinaryOutputArchive(std::ostream & stream) CEREAL_NOEXCEPT :
OutputArchive<BinaryOutputArchive, AllowEmptyClassElision>(this),
itsStream(stream)
{ }
Expand Down Expand Up @@ -89,7 +89,7 @@ namespace cereal
{
public:
//! Construct, loading from the provided stream
BinaryInputArchive(std::istream & stream) :
BinaryInputArchive(std::istream & stream) CEREAL_NOEXCEPT :
InputArchive<BinaryInputArchive, AllowEmptyClassElision>(this),
itsStream(stream)
{ }
Expand Down
4 changes: 2 additions & 2 deletions include/cereal/cereal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ namespace cereal
public:
//! Construct the output archive
/*! @param derived A pointer to the derived ArchiveType (pass this from the derived archive) */
OutputArchive(ArchiveType * const derived) : self(derived), itsCurrentPointerId(1), itsCurrentPolymorphicTypeId(1)
OutputArchive(ArchiveType * const derived) CEREAL_NOEXCEPT : self(derived), itsCurrentPointerId(1), itsCurrentPolymorphicTypeId(1)
{ }

OutputArchive & operator=( OutputArchive const & ) = delete;
Expand Down Expand Up @@ -712,7 +712,7 @@ namespace cereal
public:
//! Construct the output archive
/*! @param derived A pointer to the derived ArchiveType (pass this from the derived archive) */
InputArchive(ArchiveType * const derived) :
InputArchive(ArchiveType * const derived) CEREAL_NOEXCEPT :
self(derived),
itsBaseClassSet(),
itsSharedPointerMap(),
Expand Down