Skip to content

"Ban IP" reveals IP to non-CU #141

@Salvidrim

Description

@Salvidrim

When a non-CU tooladmin in a ticket clicks the "Ban IP" button, the ticket's underlying IP is revealed on the page where we are requested to input a reason (whether I back out or go through with it). They should be obscured just like they eventually are on the Ban Management page if a ban does go through.

I noticed when applying Ban ID 343, which, once applied, has the IP properly obscured/encrypted

In theory by inputting any ticket ID into https://utrs.wmflabs.org/banMgmt.php?appeal=XXXXX&target=1 I can reveal its IP despite not being CU.

I'm not too worried about WP:BEANS because this bug only impacts non-CU tooladmins (i.e. Jamie and me) but this should be considered high-priority

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions