From f7939a63cf7a34524c89f70040ceded6383482aa Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Fri, 4 Nov 2022 06:24:48 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- blackbox/compression.py | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/blackbox/compression.py b/blackbox/compression.py index f111e87..9b622c7 100644 --- a/blackbox/compression.py +++ b/blackbox/compression.py @@ -13,4 +13,26 @@ def uncompress(): output_path = config.get_path('output_path', 'Output') with tarfile.open(config.COMPRESSED_FILE_PATH, 'r:gz') as tar: - tar.extractall(output_path) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, output_path)