Removed Generic MLAPI message header allocation

Author: TwoTenPvP

MLAPI/MonoBehaviours/Core/NetworkingManager.cs

@@ -234,6 +234,7 @@ private ConnectionConfig Init(bool server)
             NetworkSceneManager.registeredSceneNames = new HashSet<string>();
             NetworkSceneManager.sceneIndexToString = new Dictionary<uint, string>();
             NetworkSceneManager.sceneNameToIndex = new Dictionary<string, uint>();
+            InternalMessageHandler.FinalMessageBuffer = new byte[NetworkConfig.MessageBufferSize];
 
             if(NetworkConfig.HandleObjectSpawning)
             {

MLAPI/NetworkingManagerComponents/Core/InternalMessageHandler.Send.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using MLAPI.Data;
 using MLAPI.NetworkingManagerComponents.Binary;
 using MLAPI.NetworkingManagerComponents.Cryptography;
@@ -10,6 +9,7 @@ namespace MLAPI.NetworkingManagerComponents.Core
 {
     internal static partial class InternalMessageHandler
     {
+        internal static byte[] FinalMessageBuffer;
         internal static void PassthroughSend(uint targetId, uint sourceId, ushort messageType, int channelId, byte[] data, uint? networkId = null, ushort? orderId = null)
         {
             NetId targetNetId = new NetId(targetId);
@@ -41,8 +41,10 @@ internal static void PassthroughSend(uint targetId, uint sourceId, ushort messag
                 else
                     writer.WriteByteArray(data);
 
+                writer.Finalize(ref FinalMessageBuffer);
+
                 byte error;
-                NetworkTransport.QueueMessageForSending(targetNetId.HostId, targetNetId.ConnectionId, channelId, writer.Finalize(), (int)writer.GetFinalizeSize(), out error);
+                NetworkTransport.QueueMessageForSending(targetNetId.HostId, targetNetId.ConnectionId, channelId, FinalMessageBuffer, (int)writer.GetFinalizeSize(), out error);
             }
         }
 
@@ -103,10 +105,13 @@ internal static void Send(uint clientId, string messageType, string channelName,
                 byte error;
                 if (isPassthrough)
                     netId = NetId.ServerNetId;
+
+                writer.Finalize(ref FinalMessageBuffer);
+
                 if (skipQueue)
-                    NetworkTransport.Send(netId.HostId, netId.ConnectionId, MessageManager.channels[channelName], writer.Finalize(), (int)writer.GetFinalizeSize(), out error);
+                    NetworkTransport.Send(netId.HostId, netId.ConnectionId, MessageManager.channels[channelName], FinalMessageBuffer, (int)writer.GetFinalizeSize(), out error);
                 else
-                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, MessageManager.channels[channelName], writer.Finalize(), (int)writer.GetFinalizeSize(), out error);
+                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, MessageManager.channels[channelName], FinalMessageBuffer, (int)writer.GetFinalizeSize(), out error);
             }
         }
 
@@ -149,8 +154,11 @@ internal static void Send(uint[] clientIds, string messageType, string channelNa
                         //Client trying to send data to host
                         netId = NetId.ServerNetId;
                     }
+
+                    writer.Finalize(ref FinalMessageBuffer);
+
                     byte error;
-                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, channel, writer.Finalize(), (int)writer.GetFinalizeSize(), out error);
+                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, channel, FinalMessageBuffer, (int)writer.GetFinalizeSize(), out error);
                 }
             }
         }
@@ -194,8 +202,11 @@ internal static void Send(List<uint> clientIds, string messageType, string chann
                         //Client trying to send data to host
                         netId = NetId.ServerNetId;
                     }
+
+                    writer.Finalize(ref FinalMessageBuffer);
+
                     byte error;
-                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, channel, writer.Finalize(), (int)writer.GetFinalizeSize(), out error);
+                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, channel, FinalMessageBuffer, (int)writer.GetFinalizeSize(), out error);
                 }
             }
         }
@@ -240,8 +251,11 @@ internal static void Send(string messageType, string channelName, byte[] data, u
                         //Client trying to send data to host
                         netId = NetId.ServerNetId;
                     }
+
+                    writer.Finalize(ref FinalMessageBuffer);
+
                     byte error;
-                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, channel, writer.Finalize(), (int)writer.GetFinalizeSize(), out error);
+                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, channel, FinalMessageBuffer, (int)writer.GetFinalizeSize(), out error);
                 }
             }
         }
@@ -288,8 +302,11 @@ internal static void Send(string messageType, string channelName, byte[] data, u
                         //Client trying to send data to host
                         netId = NetId.ServerNetId;
                     }
+
+                    writer.Finalize(ref FinalMessageBuffer);
+
                     byte error;
-                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, channel, writer.Finalize(), (int)writer.GetFinalizeSize(), out error);
+                    NetworkTransport.QueueMessageForSending(netId.HostId, netId.ConnectionId, channel, FinalMessageBuffer, (int)writer.GetFinalizeSize(), out error);
                 }
             }
         }