feat: Cleaned up unused MLAPI transport channel types

BREAKING CHANGE: Removed previously unused ChannelTypes

Author: TwoTenPvP

MLAPI.EnetTransport/EnetTransport.cs

@@ -265,14 +265,14 @@ public PacketFlags MLAPIChannelTypeToPacketFlag(ChannelType type)
                 {
                     return PacketFlags.Reliable;
                 }
-                case ChannelType.StateUpdate:
-                {
-                    return PacketFlags.None;
-                }
                 case ChannelType.ReliableFragmentedSequenced:
                 {
                     return PacketFlags.Reliable;
                 }
+                case ChannelType.UnreliableSequenced:
+                {
+                    return PacketFlags.None;
+                }
                 default:
                 {
                     throw new ArgumentOutOfRangeException(nameof(type), type, null);

MLAPI.RufflesTransport/RufflesTransport.cs

@@ -239,10 +239,10 @@ private Ruffles.Channeling.ChannelType ConvertChannelType(ChannelType type)
                     return Ruffles.Channeling.ChannelType.ReliableSequenced;
                 case ChannelType.ReliableSequenced:
                     return Ruffles.Channeling.ChannelType.ReliableSequenced;
-                case ChannelType.StateUpdate:
-                    return Ruffles.Channeling.ChannelType.Unreliable;
                 case ChannelType.Unreliable:
                     return Ruffles.Channeling.ChannelType.Unreliable;
+                case ChannelType.UnreliableSequenced:
+                    return Ruffles.Channeling.ChannelType.UnreliableSequenced;
             }
 
             return Ruffles.Channeling.ChannelType.Reliable;

MLAPI/Transports/ChannelType.cs

@@ -10,10 +10,6 @@ public enum ChannelType
         /// </summary>
         Unreliable,
         /// <summary>
-        /// Unreliable with fragmentation support
-        /// </summary>
-        UnreliableFragmented,
-        /// <summary>
         /// Unreliable with sequencing
         /// </summary>
         UnreliableSequenced,
@@ -22,30 +18,10 @@ public enum ChannelType
         /// </summary>
         Reliable,
         /// <summary>
-        /// Reliable with fragmentation support
-        /// </summary>
-        ReliableFragmented,
-        /// <summary>
         /// Reliable message where messages are guaranteed to be in the right order
         /// </summary>
         ReliableSequenced,
         /// <summary>
-        /// A unreliable state update message
-        /// </summary>
-        StateUpdate,
-        /// <summary>
-        /// A reliable state update message
-        /// </summary>
-        ReliableStateUpdate,
-        /// <summary>
-        /// A reliable message with high priority
-        /// </summary>
-        AllCostDelivery,
-        /// <summary>
-        /// Unreliable message with fragmentation where older messages are dropped
-        /// </summary>
-        UnreliableFragmentedSequenced,
-        /// <summary>
         /// A reliable message with guaranteed order with fragmentation support
         /// </summary>
         ReliableFragmentedSequenced

MLAPI/Transports/Transport.cs

@@ -32,7 +32,7 @@ public abstract class Transport : MonoBehaviour
             new TransportChannel()
             {
                 Name = "MLAPI_POSITION_UPDATE",
-                Type = ChannelType.StateUpdate
+                Type = ChannelType.UnreliableSequenced
             },
             new TransportChannel()
             {
@@ -47,7 +47,7 @@ public abstract class Transport : MonoBehaviour
             new TransportChannel()
             {
                 Name = "MLAPI_NAV_AGENT_CORRECTION",
-                Type = ChannelType.StateUpdate
+                Type = ChannelType.UnreliableSequenced
             },
             new TransportChannel()
             {

MLAPI/Transports/UNET/UnetTransport.cs

@@ -273,11 +273,12 @@ public int AddMLAPIChannel(ChannelType type, ConnectionConfig config)
                     return config.AddChannel(QosType.Reliable);
                 case ChannelType.ReliableSequenced:
                     return config.AddChannel(QosType.ReliableSequenced);
-                case ChannelType.StateUpdate:
-                    return config.AddChannel(QosType.StateUpdate);
                 case ChannelType.ReliableFragmentedSequenced:
                     return config.AddChannel(QosType.ReliableFragmentedSequenced);
+                case ChannelType.UnreliableSequenced:
+                    return config.AddChannel(QosType.UnreliableSequenced);
             }
+
             return 0;
         }
 
@@ -308,6 +309,7 @@ public int AddUNETChannel(QosType type, ConnectionConfig config)
                 case QosType.ReliableFragmentedSequenced:
                     return config.AddChannel(QosType.ReliableFragmentedSequenced);
             }
+
             return 0;
         }