fix: Correcting the profiler names for network vars to be appropriately named. Should address issue #605 (#632)

Author: kvassall-unity

com.unity.multiplayer.mlapi/Editor/MLAPIProfilerModule.cs

@@ -68,7 +68,8 @@ private class MLAPIModules
             new MLAPIProfilerCounter { m_Name = ProfilerConstants.UnnamedMessageReceived, m_Category = ProfilerCategory.Network.Name },
             new MLAPIProfilerCounter { m_Name = ProfilerConstants.ByteSent, m_Category = ProfilerCategory.Network.Name },
             new MLAPIProfilerCounter { m_Name = ProfilerConstants.ByteReceived, m_Category = ProfilerCategory.Network.Name },
-            new MLAPIProfilerCounter { m_Name = ProfilerConstants.NetworkVarReceived, m_Category = ProfilerCategory.Network.Name },
+            new MLAPIProfilerCounter { m_Name = ProfilerConstants.NetworkVarUpdates, m_Category = ProfilerCategory.Network.Name },
+            new MLAPIProfilerCounter { m_Name = ProfilerConstants.NetworkVarDeltas, m_Category = ProfilerCategory.Network.Name },
         };
 
         private delegate List<MLAPIProfilerCounter> CounterListFactoryDelegate();

com.unity.multiplayer.mlapi/Runtime/Core/NetworkBehaviour.cs

@@ -729,7 +729,7 @@ internal static void HandleNetworkVariableDeltas(List<INetworkVariable> networkV
                     long readStartPos = stream.Position;
 
                     networkVariableList[i].ReadDelta(stream, IsServer, localTick, remoteTick);
-                    PerformanceDataManager.Increment(ProfilerConstants.NetworkVarReceived);
+                    PerformanceDataManager.Increment(ProfilerConstants.NetworkVarDeltas);
 
                     ProfilerStatManager.NetworkVarsRcvd.Record();
 
@@ -810,7 +810,7 @@ internal static void HandleNetworkVariableUpdate(List<INetworkVariable> networkV
                     long readStartPos = stream.Position;
 
                     networkVariableList[i].ReadField(stream, NetworkTickSystem.NoTick, NetworkTickSystem.NoTick);
-                    PerformanceDataManager.Increment(ProfilerConstants.NetworkVarReceived);
+                    PerformanceDataManager.Increment(ProfilerConstants.NetworkVarUpdates);
 
                     ProfilerStatManager.NetworkVarsRcvd.Record();
 

com.unity.multiplayer.mlapi/Runtime/Profiling/ProfilerConstants.cs

@@ -9,7 +9,8 @@ public static class ProfilerConstants
         public const string UnnamedMessageReceived = nameof(UnnamedMessageReceived);
         public const string ByteSent = nameof(ByteSent);
         public const string ByteReceived = nameof(ByteReceived);
-        public const string NetworkVarReceived = nameof(NetworkVarReceived);
+        public const string NetworkVarDeltas = nameof(NetworkVarDeltas);
+        public const string NetworkVarUpdates = nameof(NetworkVarUpdates);
         public const string RpcSent = nameof(RpcSent);
         public const string RpcReceived = nameof(RpcReceived);
         public const string RpcBatchesSent = nameof(RpcBatchesSent);

com.unity.multiplayer.mlapi/Runtime/Profiling/ProfilerCountersInfo.cs

@@ -34,8 +34,12 @@ internal static class ProfilerCountersInfo
             new ProfilerCounterValue<int>(ProfilerCategory.Network, ProfilerConstants.ByteReceived,
                 ProfilerMarkerDataUnit.Count, ProfilerCounterOptions.FlushOnEndOfFrame | ProfilerCounterOptions.ResetToZeroOnFlush);
 
-        private static readonly ProfilerCounterValue<int> k_NetworkVarsCounterValue =
-            new ProfilerCounterValue<int>(ProfilerCategory.Network, ProfilerConstants.NetworkVarReceived,
+        private static readonly ProfilerCounterValue<int> k_NetworkVarDeltasCounterValue =
+            new ProfilerCounterValue<int>(ProfilerCategory.Network, ProfilerConstants.NetworkVarDeltas,
+                ProfilerMarkerDataUnit.Count, ProfilerCounterOptions.FlushOnEndOfFrame | ProfilerCounterOptions.ResetToZeroOnFlush);
+
+        private static readonly ProfilerCounterValue<int> k_NetworkVarUpdatesCounterValue =
+            new ProfilerCounterValue<int>(ProfilerCategory.Network, ProfilerConstants.NetworkVarUpdates,
                 ProfilerMarkerDataUnit.Count, ProfilerCounterOptions.FlushOnEndOfFrame | ProfilerCounterOptions.ResetToZeroOnFlush);
 
         // RPCs
@@ -83,7 +87,8 @@ private static void InitializeCounters()
             k_UnnamedMessagesCounterValue.Value = 0;
             k_BytesSentCounterValue.Value = 0;
             k_BytesReceivedCounterValue.Value = 0;
-            k_NetworkVarsCounterValue.Value = 0;
+            k_NetworkVarDeltasCounterValue.Value = 0;
+            k_NetworkVarUpdatesCounterValue.Value = 0;
 
             k_RPCsSentCounterValue.Value = 0;
             k_RPCsReceivedCounterValue.Value = 0;
@@ -105,7 +110,8 @@ private static void OnPerformanceTickData(PerformanceTickData tickData)
             UpdateIntCounter(tickData, k_UnnamedMessagesCounterValue, ProfilerConstants.UnnamedMessageReceived);
             UpdateIntCounter(tickData, k_BytesSentCounterValue, ProfilerConstants.ByteSent);
             UpdateIntCounter(tickData, k_BytesReceivedCounterValue, ProfilerConstants.ByteReceived);
-            UpdateIntCounter(tickData, k_NetworkVarsCounterValue, ProfilerConstants.NetworkVarReceived);
+            UpdateIntCounter(tickData, k_NetworkVarDeltasCounterValue, ProfilerConstants.NetworkVarDeltas);
+            UpdateIntCounter(tickData, k_NetworkVarUpdatesCounterValue, ProfilerConstants.NetworkVarUpdates);
 
             // RPCs
             UpdateIntCounter(tickData, k_RPCsSentCounterValue, ProfilerConstants.RpcSent);