Implicitly define minimum and maximum for integer types

Author: kraigher

vhdl_lang/src/analysis/declarative.rs

@@ -625,6 +625,7 @@ impl<'a> AnalyzeContext<'a> {
                     parent.add_named_entity(to_string.clone(), diagnostics);
                     implicit.push(Arc::downgrade(&to_string));
                 }
+
                 parent.add_named_entity(
                     Arc::new(type_ent.clone_with_kind(NamedEntityKind::Type(Type::Array {
                         implicit: Vec::new(),
@@ -693,6 +694,18 @@ impl<'a> AnalyzeContext<'a> {
                     parent.add_named_entity(to_string.clone(), diagnostics);
                     implicit.push(Arc::downgrade(&to_string));
                 }
+
+                {
+                    let minimum = Arc::new(self.create_min_or_maximum("MINMUM", type_ent.clone()));
+                    parent.add_named_entity(minimum.clone(), diagnostics);
+                    implicit.push(Arc::downgrade(&minimum));
+                }
+
+                {
+                    let maximum = Arc::new(self.create_min_or_maximum("MAXIMUM", type_ent.clone()));
+                    parent.add_named_entity(maximum.clone(), diagnostics);
+                    implicit.push(Arc::downgrade(&maximum));
+                }
                 parent.add_named_entity(
                     Arc::new(
                         type_ent.clone_with_kind(NamedEntityKind::Type(Type::Integer(implicit))),
@@ -856,6 +869,40 @@ impl<'a> AnalyzeContext<'a> {
         )
     }
 
+    /// Create implicit MAXIMUM/MINIMUM
+    // function MINIMUM (L, R: T) return T;
+    // function MAXIMUM (L, R: T) return T;
+    pub fn create_min_or_maximum(&self, name: &str, type_ent: TypeEnt) -> NamedEntity {
+        let mut params = ParameterList::default();
+        params.add_param(Arc::new(NamedEntity::new(
+            self.symbol_utf8("L"),
+            NamedEntityKind::Object(Object {
+                class: ObjectClass::Constant,
+                mode: Some(Mode::In),
+                subtype: Subtype::new(type_ent.to_owned()),
+                has_default: false,
+            }),
+            type_ent.decl_pos(),
+        )));
+
+        params.add_param(Arc::new(NamedEntity::new(
+            self.symbol_utf8("R"),
+            NamedEntityKind::Object(Object {
+                class: ObjectClass::Constant,
+                mode: Some(Mode::In),
+                subtype: Subtype::new(type_ent.to_owned()),
+                has_default: false,
+            }),
+            type_ent.decl_pos(),
+        )));
+
+        NamedEntity::implicit(
+            self.symbol_utf8(name),
+            NamedEntityKind::Subprogram(Signature::new(params, Some(type_ent.clone()))),
+            type_ent.decl_pos(),
+        )
+    }
+
     pub fn resolve_signature(
         &self,
         region: &Region<'_>,

vhdl_libraries/std/standard.vhd

@@ -94,8 +94,6 @@ package standard is
   function FALLING_EDGE(signal S: BOOLEAN) return BOOLEAN;
   function FALLING_EDGE(signal B: BIT) return BOOLEAN;
 
-  function MAXIMUM return NATURAL;
-  function MINIMUM return NATURAL;
   procedure DEALLOCATE;
 
 end package;