Merge pull request #1546 from VWS-Python/wemake

Satisfy some wemake rules

Author: adamtheturtle

docs/source/conf.py

@@ -81,7 +81,7 @@
 linkcheck_retries = 5
 linkcheck_ignore = [
     # Requires login.
-    r"https://developer.vuforia.com/targetmanager",
+    "https://developer.vuforia.com/targetmanager",
 ]
 
 spelling_word_list_filename = "../../spelling_private_dict.txt"

src/mock_vws/_base64_decoding.py

@@ -13,7 +13,7 @@ def decode_base64(encoded_data: str) -> bytes:
 
     Raises:
         binascii.Error: Vuforia would consider this encoded data as an
-        "UNPROCESSABLE_ENTITY".
+          "UNPROCESSABLE_ENTITY".
 
     Returns:
         The given data, decoded as base64.
@@ -23,13 +23,13 @@ def decode_base64(encoded_data: str) -> bytes:
         if character not in acceptable_characters:
             raise binascii.Error
 
-    mod_4_result_to_modified_encoded_data = {
+    mod_four_result_to_modified_encoded_data = {
         0: encoded_data,
         1: encoded_data[:-1],
-        2: encoded_data + "==",
-        3: encoded_data + "=",
+        2: f"{encoded_data}==",
+        3: f"{encoded_data}=",
     }
-    modified_encoded_data = mod_4_result_to_modified_encoded_data[
+    modified_encoded_data = mod_four_result_to_modified_encoded_data[
         len(encoded_data) % 4
     ]
     return base64.b64decode(modified_encoded_data)

src/mock_vws/_flask_server/target_manager.py

@@ -179,11 +179,11 @@ def create_target(database_name: str) -> Response:
     """
     Create a new target in a given database.
     """
-    [database] = [
+    (database,) = (
         database
         for database in TARGET_MANAGER.databases
         if database.database_name == database_name
-    ]
+    )
     request_json = json.loads(request.data)
     image_base64 = request_json["image_base64"]
     image_bytes = base64.b64decode(s=image_base64)
@@ -216,11 +216,11 @@ def delete_target(database_name: str, target_id: str) -> Response:
     """
     Delete a target.
     """
-    [database] = [
+    (database,) = (
         database
         for database in TARGET_MANAGER.databases
         if database.database_name == database_name
-    ]
+    )
     target = database.get_target(target_id=target_id)
     now = datetime.datetime.now(tz=target.upload_date.tzinfo)
     new_target = dataclasses.replace(target, delete_date=now)
@@ -240,11 +240,11 @@ def update_target(database_name: str, target_id: str) -> Response:
     """
     Update a target.
     """
-    [database] = [
+    (database,) = (
         database
         for database in TARGET_MANAGER.databases
         if database.database_name == database_name
-    ]
+    )
     target = database.get_target(target_id=target_id)
 
     request_json = json.loads(request.data)
@@ -285,4 +285,4 @@ def update_target(database_name: str, target_id: str) -> Response:
 
 if __name__ == "__main__":  # pragma: no cover
     SETTINGS = TargetManagerSettings.parse_obj(obj={})
-    TARGET_MANAGER_FLASK_APP.run(debug=True, host=SETTINGS.target_manager_host)
+    TARGET_MANAGER_FLASK_APP.run(host=SETTINGS.target_manager_host)

src/mock_vws/_flask_server/vwq.py

@@ -162,4 +162,4 @@ def query() -> Response:
 
 if __name__ == "__main__":  # pragma: no cover
     SETTINGS = VWQSettings.parse_obj(obj={})
-    CLOUDRECO_FLASK_APP.run(debug=True, host=SETTINGS.vwq_host)
+    CLOUDRECO_FLASK_APP.run(host=SETTINGS.vwq_host)

src/mock_vws/_flask_server/vws.py

@@ -78,9 +78,10 @@ def get_all_databases() -> set[VuforiaDatabase]:
     Get all database objects from the task manager back-end.
     """
     settings = VWSSettings.parse_obj(obj={})
+    timeout_seconds = 30
     response = requests.get(
         url=f"{settings.target_manager_base_url}/databases",
-        timeout=30,
+        timeout=timeout_seconds,
     )
     return {
         VuforiaDatabase.from_dict(database_dict=database_dict)
@@ -182,10 +183,11 @@ def add_target() -> Response:
     )
 
     databases_url = f"{settings.target_manager_base_url}/databases"
+    timeout_seconds = 30
     requests.post(
         url=f"{databases_url}/{database.database_name}/targets",
         json=new_target.to_dict(),
-        timeout=30,
+        timeout=timeout_seconds,
     )
 
     date = email.utils.formatdate(None, localtime=False, usegmt=True)
@@ -230,9 +232,9 @@ def get_target(target_id: str) -> Response:
     )
 
     assert isinstance(database, VuforiaDatabase)
-    [target] = [
+    (target,) = (
         target for target in database.targets if target.target_id == target_id
-    ]
+    )
 
     target_record = {
         "target_id": target.target_id,
@@ -285,9 +287,9 @@ def delete_target(target_id: str) -> Response:
     )
 
     assert isinstance(database, VuforiaDatabase)
-    [target] = [
+    (target,) = (
         target for target in database.targets if target.target_id == target_id
-    ]
+    )
 
     if target.status == TargetStatuses.PROCESSING.value:
         raise TargetStatusProcessing
@@ -390,9 +392,9 @@ def target_summary(target_id: str) -> Response:
     )
 
     assert isinstance(database, VuforiaDatabase)
-    [target] = [
+    (target,) = (
         target for target in database.targets if target.target_id == target_id
-    ]
+    )
     body = {
         "status": target.status,
         "transaction_id": uuid.uuid4().hex,
@@ -443,9 +445,9 @@ def get_duplicates(target_id: str) -> Response:
     image_match_checker = settings.duplicates_image_matcher.to_image_matcher()
 
     assert isinstance(database, VuforiaDatabase)
-    [target] = [
+    (target,) = (
         target for target in database.targets if target.target_id == target_id
-    ]
+    )
     other_targets = database.targets - {target}
 
     similar_targets: list[str] = [
@@ -455,7 +457,7 @@ def get_duplicates(target_id: str) -> Response:
             first_image_content=target.image_value,
             second_image_content=other.image_value,
         )
-        and TargetStatuses.FAILED.value not in (target.status, other.status)
+        and TargetStatuses.FAILED.value not in {target.status, other.status}
         and TargetStatuses.PROCESSING.value != other.status
         and other.active_flag
     ]
@@ -546,9 +548,9 @@ def update_target(target_id: str) -> Response:
     )
 
     assert isinstance(database, VuforiaDatabase)
-    [target] = [
+    (target,) = (
         target for target in database.targets if target.target_id == target_id
-    ]
+    )
 
     if target.status != TargetStatuses.SUCCESS.value:
         raise TargetStatusNotSuccess
@@ -590,8 +592,8 @@ def update_target(target_id: str) -> Response:
         update_values["image"] = image
 
     put_url = (
-        f"{settings.target_manager_base_url}/databases/{database.database_name}/"
-        f"targets/{target_id}"
+        f"{settings.target_manager_base_url}/databases/"
+        f"{database.database_name}/targets/{target_id}"
     )
     requests.put(url=put_url, json=update_values, timeout=30)
 
@@ -618,4 +620,4 @@ def update_target(target_id: str) -> Response:
 
 if __name__ == "__main__":  # pragma: no cover
     SETTINGS = VWSSettings.parse_obj(obj={})
-    VWS_FLASK_APP.run(debug=True, host=SETTINGS.vws_host)
+    VWS_FLASK_APP.run(host=SETTINGS.vws_host)

src/mock_vws/_query_tools.py

@@ -145,7 +145,7 @@ def get_query_match_response_text(
         raise ActiveMatchingTargetsDeleteProcessing
 
     all_quality_matches = not_deleted_matches + deletion_not_recognized_matches
-    minimum_rating = 0.0
+    minimum_rating = 0
     matches = [
         match
         for match in all_quality_matches

src/mock_vws/_query_validators/accept_header_validators.py

@@ -22,7 +22,7 @@ def validate_accept_header(request_headers: dict[str, str]) -> None:
             'application/json' or '*/*'.
     """
     accept = request_headers.get("Accept")
-    if accept in ("application/json", "*/*", None):
+    if accept in {"application/json", "*/*", None}:
         return
 
     _LOGGER.warning(

src/mock_vws/_query_validators/content_type_validators.py

@@ -42,7 +42,7 @@ def validate_content_type_header(
 
     email_message = EmailMessage()
     email_message["content-type"] = request_headers["Content-Type"]
-    if email_message.get_content_type() not in ("multipart/form-data", "*/*"):
+    if email_message.get_content_type() not in {"multipart/form-data", "*/*"}:
         _LOGGER.warning(
             msg=(
                 "The content type header main part is not multipart/form-data."

src/mock_vws/_query_validators/date_validators.py

@@ -47,12 +47,10 @@ def _accepted_date_formats() -> set[str]:
         "%a %d %b %Y %H:%M:%S",
     }
 
-    known_accepted_formats = known_accepted_formats.union(
-        {date_format + " GMT" for date_format in known_accepted_formats},
+    return known_accepted_formats.union(
+        {f"{date_format} GMT" for date_format in known_accepted_formats},
     )
 
-    return known_accepted_formats
-
 
 def validate_date_format(request_headers: dict[str, str]) -> None:
     """
@@ -95,7 +93,7 @@ def validate_date_in_range(request_headers: dict[str, str]) -> None:
                 date_format,
             ).astimezone()
 
-    assert date is not None
+    assert isinstance(date, datetime.datetime)
     gmt = ZoneInfo("GMT")
     now = datetime.datetime.now(tz=gmt)
     date_from_header = date.replace(tzinfo=gmt)

src/mock_vws/_query_validators/fields_validators.py

@@ -34,7 +34,7 @@ def validate_extra_fields(
     boundary = email_message.get_boundary()
     assert isinstance(boundary, str)
     parsed = multipart.MultipartParser(stream=body_file, boundary=boundary)
-    parsed_keys = {item.name for item in parsed.parts()}
+    parsed_keys = {part.name for part in parsed.parts()}
     known_parameters = {"image", "max_num_results", "include_target_data"}
 
     if not parsed_keys - known_parameters: