Questions regarding BSMT2000 support

[toxieainc]

Hi!

I'm currently trying to add BSMT2000 VGM export to PinMAME. But the current result, when played back with the current master libvgm test program, is pretty broken (e.g. some stuff played too fast, wrong samples).
One reason for the DataEast/Sega/Stern pinball machines may be the bank switch behavior: here i wonder how libvgm deals with that, is it just relying on the ROM data being passed pre-scrambled to the vgm logger? How does MAME do it? Do you know?
But i also get pretty broken behavior for Alvin G. pinball machines (which do not feature the special bank behavior).
So i wonder, is the feature still WIP, or is it already working when exporting VGMs from MAME and playing them back either in libvgmtest/vgmplay or MAMEs vgmplayer itself?

Thanks!!

[ValleyBell]

My test cases were the MAME ROMs btoads and tattass and those worked fine so far.
I don't think they have custom banking though.

Right now, libvgm assumes that there is no special ROM banking involved.
When there is banking, I either "pre-scramble" the ROM data or implement additional banking (with special "set ROM bank" commands) into the sound core. I did the latter to allow for NMK112 banking.

[toxieainc]

Hi! Could you maybe please try Alvin G.'s wrldtour and Data Easts tftc_303, if these work?
At the moment i'm not sure which part i did wrong, so it would be nice if you could confirm if these work (or don't). Thanks!

[ValleyBell]

I finally tested those two ROMs in MAME 0.280 VGM and the small bits of sound there that MAME played where logged just fine and sound the same in libvgm/VGMPlay.

I attached the logged VGMs here: VGM-logs.zip (will remove them at some point later)

EDIT: The ROM dumps included in the VGMs seem to be overdumps (only 1 MiB or 4 MiB used, but 16 MiB dumped).
This shouldn't have any bad side effect though. I can just set the ROM size to the actual used size in the VGM and it still works fine. (And this would actually be my preferred way of having this dumped. MAME just makes this hard in some cases.)