From c9b52727946f3a41ddf78d11b817e109eebf6171 Mon Sep 17 00:00:00 2001 From: Dewi-Tim Davies Date: Mon, 12 Jan 2026 00:25:43 +0100 Subject: [PATCH] Fix reversed bounds check in Cmd_PcmRamWrite Co-Authored-By: Claude --- player/vgmplayer_cmdhandler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/player/vgmplayer_cmdhandler.cpp b/player/vgmplayer_cmdhandler.cpp index 4a3eee48..1f0131b3 100644 --- a/player/vgmplayer_cmdhandler.cpp +++ b/player/vgmplayer_cmdhandler.cpp @@ -821,7 +821,7 @@ void VGMPlayer::Cmd_PcmRamWrite(void) const UINT8* ROMData = &_pcmBank[dbType].data[dbPos]; if (! dataLen) dataLen += 0x01000000; - if (_pcmBank[dbType].data.size() - dbPos > dataLen) + if (dataLen > _pcmBank[dbType].data.size() - dbPos) return; // just outright ignore writes that would go out-of-bounds if (chipType == 0x14) // NES APU