-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is neededphase 1 - theoryPhase 1 of the roadmap, focusing on theory completenessPhase 1 of the roadmap, focusing on theory completeness
Description
Clarify and implement sumToIter
Summary
Clarify the intended behavior of sumToIter and implement it. The current TODO notes that the behavior needs clarification - it may be related to converting between different polynomial representations or evaluation strategies.
Context
Part of Phase 1: Foundation Completion (API completeness) as outlined in ROADMAP.md line 60. The function signature exists but the intended behavior is unclear.
What to Implement
sumToIter {n : ℕ} {R : Type} [CommSemiring R] [BEq R] [LawfulBEq R] (p : CMvPolynomial n R) : CMvPolynomial n R
- Convert sum representation to iterative form
- Location:
CompPoly/Multivariate/CMvPolynomial.leanline 284 - Needs clarification: What is "iterative form" vs "sum representation"?
Questions to Resolve
- What is the difference between "sum representation" and "iterative form"?
- Is this related to:
- Converting between different internal representations?
- Evaluation strategies (Horner's method vs direct evaluation)?
- Normalization of polynomial structure?
- Should this be an identity function (no-op) if representations are the same?
- Is there a Mathlib equivalent we should match?
Potential Interpretations
- Horner's method conversion: Convert from sum-of-monomials to nested multiplication form
- Representation normalization: Convert between different internal data structures
- Evaluation optimization: Pre-process polynomial for iterative evaluation
- No-op: If
CMvPolynomialalready uses the "iterative" representation
Dependencies
- Understanding of intended behavior (needs clarification)
CMvPolynomialinternal structure- Possibly evaluation functions
Mathlib References
- Need to search Mathlib for similar concepts
- May not have a direct equivalent if this is CompPoly-specific
Success Criteria
- Intended behavior is clarified and documented
- Function is implemented according to specification
- Basic properties are proven (e.g., idempotency if applicable)
- Relationship to other operations is established
Tags
phase-1api-completenessmultivariate-polynomialsneeds-clarificationquestion
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is neededphase 1 - theoryPhase 1 of the roadmap, focusing on theory completenessPhase 1 of the roadmap, focusing on theory completeness