Keep loader in minecraft brand

[OffsetMonkey538]

Vivecraft seems to replace the client brand with "vivecraft" regardless of loader used. I propose this should be changed to "vivecraft-$loader" like "vivecraft-fabric" or "vivecraft-neoforge". Even better if the original value of thr getBrand method could be kept, so it'd get "vivecraft-quilt" automatically or whatever else could be there

[fayer3]

sounds fine, but is there any issue with the current way?

[OffsetMonkey538]

I collect telemetry data and base my loader usage detection off of the game brand, so vivecraft showing up without mentioning the loader is a bit unhelpful

[fayer3]

hm, okay

[OffsetMonkey538]

(Just got some time to look at the code and it) Looks like it's just being modified with a mixin https://github.com/Vivecraft/VivecraftMod/blob/Multiloader-1.21.11/common%2Fsrc%2Fmain%2Fjava%2Forg%2Fvivecraft%2Fmixin%2Fclient_vr%2FClientBrandRetrieverVRMixin.java where the injecr could just be easily replaced with a ModifyReturnValue from mixinextras and returning "vivecraft-" + original

[fayer3]

yes I can do that, just not sure if some server expects it to exactly vivecraft, since that is what it is since 1.14