Email address in place of username and domain

[fdiengdoh]

First of all thanks for this simple yet effective code.

I'm not so sure if this is the right place to ask about this, but I would like to mention that while generating QR code this code is used

TokenAuth6238::getBarCodeUrl( 'user', 'domain', $secretkey, 'websiteservice' ))

now when scan by an app, it shows user@domain. The problem is as a user, I may find it difficult to link the two, when I use an email to login to a service. So, as a developer, I want to implement something like this

TokenAuth6238::getBarCodeUrl( 'email@address',$secretkey, 'websiteservice' ))

For my project I'm planning to tweak the core code as follows

public static function getBarCodeUrl($useremail, $secretkey, $issuer) {
      $url = "http://chart.apis.google.com/chart";
      $url = $url . "?chs=200x200&chld=M|0&cht=qr&chl=otpauth://totp/";
      $url = $url . $useremail . "%3Fsecret%3D" . $secretkey . '%26issuer%3D' . rawurlencode($issuer);
      
      return $url;
    }

But I'm afraid it would break there is any update to this library.

[Voronenko]

Well, this is rather simple proof of concept demo project.
Nowadays for php there are good mature libraries conforming PHP standars, supporting both HOTP & TOTP tokens, and you are highly invited to use them.

Purpose of this repo is to show that no mystery behind.

[Voronenko]

Some I could recommend are

https://github.com/Spomky-Labs/otphp

https://github.com/lelag/otphp

[fdiengdoh]

Thanks,

Well, this is rather simple proof of concept demo project.

so does it means this demo is not supposed to be use on a production environment? Because I really like the simplicity of this.

[fdiengdoh]

Some I could recommend are
https://github.com/Spomky-Labs/otphp
https://github.com/lelag/otphp

Ok, thanks again, would take a look at those.

[Voronenko]

Well you can adapt it to your application, but I would definitely look into transforming it into some PSR favor with namespaces.