I think there is an issue with the renderFormPage function

[engmoe88]

Hi Kyle!
I think there is an issue with this function
async function renderFormPage(res, book, form, hasError = false) { try { const authors = await Author.find({}) const params = { authors: authors, book: book } if (hasError) { if (form === 'edit') { params.errorMessage = 'Error Updating Book' } else { params.errorMessage = 'Error Creating Book' } } res.render(books/${form}, params) } catch { res.redirect('/books') } }
On this commit. Here is the repro steps:
1- Start your server (after you have pulled the changes from the commit mentioned above
2- Go to "Add Book" and click it
3- Don't fill in any of the fields and click "Create"

Actual Result:
The browser will keep loading and nothing happens and then the app will crash.

Expected Result:
The app should redirect the user back to the /books/new page and populate all of the fields that were populated at the initial creation of the book. In my case where non of the fields was populated it should bring me back to the /books/new page and all fields should be empty.

Thanks!
Mohammed

[engmoe88]

Update:
The easiest and fast and dirty way for me to go around this issue and mitigate it is to mark all the fields in the _form_fields.ejs of the books views as required (except for the file input so that it doesn't affect updating a book if needs be) so that the validation happens on the browser.

[fuji0shi]

Hi,
Maybe try an abstract equality comparison instead of a strict equality comparison on the if (form ==='edit')

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness

Have a good day,
Radjee

[iuriirudov]

Hi Kyle!
I think there is an issue with this function
async function renderFormPage(res, book, form, hasError = false) { try { const authors = await Author.find({}) const params = { authors: authors, book: book } if (hasError) { if (form === 'edit') { params.errorMessage = 'Error Updating Book' } else { params.errorMessage = 'Error Creating Book' } } res.render(books/${form}, params) } catch { res.redirect('/books') } }
On this commit. Here is the repro steps:
1- Start your server (after you have pulled the changes from the commit mentioned above
2- Go to "Add Book" and click it
3- Don't fill in any of the fields and click "Create"

Actual Result:
The browser will keep loading and nothing happens and then the app will crash.

Expected Result:
The app should redirect the user back to the /books/new page and populate all of the fields that were populated at the initial creation of the book. In my case where non of the fields was populated it should bring me back to the /books/new page and all fields should be empty.

Thanks!
Mohammed

Forms send empty strings.
Inside books route find a function saveCover and change this:
if(coverEncoded == null) return
onto this:
if(coverEncoded == null || coverEncoded.length < 1) return

[Ilham-Nugroho]

Hi Kyle!
I think there is an issue with this function
async function renderFormPage(res, book, form, hasError = false) { try { const authors = await Author.find({}) const params = { authors: authors, book: book } if (hasError) { if (form === 'edit') { params.errorMessage = 'Error Updating Book' } else { params.errorMessage = 'Error Creating Book' } } res.render(books/${form}, params) } catch { res.redirect('/books') } }
On this commit. Here is the repro steps:
1- Start your server (after you have pulled the changes from the commit mentioned above
2- Go to "Add Book" and click it
3- Don't fill in any of the fields and click "Create"
Actual Result:
The browser will keep loading and nothing happens and then the app will crash.
Expected Result:
The app should redirect the user back to the /books/new page and populate all of the fields that were populated at the initial creation of the book. In my case where non of the fields was populated it should bring me back to the /books/new page and all fields should be empty.
Thanks!
Mohammed

Forms send empty strings.
Inside books route find a function saveCover and change this:
if(coverEncoded == null) return
onto this:
if(coverEncoded == null || coverEncoded.length < 1) return

this works, thanks!

[sjchae416]

Hi Kyle!
I think there is an issue with this function
async function renderFormPage(res, book, form, hasError = false) { try { const authors = await Author.find({}) const params = { authors: authors, book: book } if (hasError) { if (form === 'edit') { params.errorMessage = 'Error Updating Book' } else { params.errorMessage = 'Error Creating Book' } } res.render(books/${form}, params) } catch { res.redirect('/books') } }
On this commit. Here is the repro steps:
1- Start your server (after you have pulled the changes from the commit mentioned above
2- Go to "Add Book" and click it
3- Don't fill in any of the fields and click "Create"
Actual Result:
The browser will keep loading and nothing happens and then the app will crash.
Expected Result:
The app should redirect the user back to the /books/new page and populate all of the fields that were populated at the initial creation of the book. In my case where non of the fields was populated it should bring me back to the /books/new page and all fields should be empty.
Thanks!
Mohammed

Forms send empty strings. Inside books route find a function saveCover and change this: if(coverEncoded == null) return onto this: if(coverEncoded == null || coverEncoded.length < 1) return

Works like a charm!
Thanks for the solution and the problem.
I didn't notice until now.