From 3ff31b6955a53b075348770bc0798728dcbde0da Mon Sep 17 00:00:00 2001 From: Corey Collins Date: Sat, 8 Dec 2018 22:45:28 -0600 Subject: [PATCH 1/2] Removes the error message causing 500 on search results not found --- class-wds-react-post-search.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/class-wds-react-post-search.php b/class-wds-react-post-search.php index 5b42b79..de761d5 100644 --- a/class-wds-react-post-search.php +++ b/class-wds-react-post-search.php @@ -407,10 +407,6 @@ public function search_posts( $request ) { endforeach; endif; - if ( empty( $results ) ) : - return new WP_Error( 'wds-react-post-search-results', apply_filters( 'wds_react_post_search_no_results_text', esc_html__( 'No results found.', 'wds-react-post-search' ) ) ); - endif; - return rest_ensure_response( $results ); } } From 479090142d191a52d2445756e4061f29035703ff Mon Sep 17 00:00:00 2001 From: Corey Collins Date: Sat, 8 Dec 2018 22:45:48 -0600 Subject: [PATCH 2/2] Replaces our custom route with /wp/v2/ --- class-wds-react-post-search.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/class-wds-react-post-search.php b/class-wds-react-post-search.php index de761d5..bab5df5 100644 --- a/class-wds-react-post-search.php +++ b/class-wds-react-post-search.php @@ -249,7 +249,7 @@ public function enqueue_scripts() { wp_enqueue_style( 'wds-react-post-search-styles' ); wp_localize_script( 'wds-react-post-search', 'wds_react_post_search', array( - 'rest_search_posts' => rest_url( 'wds-react-post-search/v1/search' ), + 'rest_search_posts' => rest_url( 'wp/v2/search' ), 'loading_text' => apply_filters( 'wds_react_post_search_loading_text', esc_html__( 'Loading results...', 'wds-react-post-search' ) ), 'no_results_text' => apply_filters( 'wds_react_post_search_no_results_text', esc_html__( 'No results found.', 'wds-react-post-search' ) ), 'length_error' => apply_filters( 'wds_react_post_search_length_error_text', esc_html__( 'Please enter at least 3 characters.', 'wds-react-post-search' ) ), @@ -329,7 +329,7 @@ public function post_types_to_search() { * @return void */ public function rest_api_init() { - register_rest_route('wds-react-post-search/v1', '/search', [ + register_rest_route( 'wp/v2', '/search', [ 'methods' => WP_REST_Server::READABLE, 'callback' => array( $this, 'search_posts' ), 'args' => $this->get_search_args(),