Skip to content

Optimize hoisted static content #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WebReflection opened this issue Jun 17, 2021 · 0 comments
Open

Optimize hoisted static content #2

WebReflection opened this issue Jun 17, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@WebReflection
Copy link
Owner

WebReflection commented Jun 17, 2021

Based on this tweet, and its code example, "truly constant elements" are passed right away as children.

uhtml and friends have this Hole class concept, that would make it kinda easier to aggregate children as arrray, but there's no way to pass this check around and help other cases too, and currently, the logic doesn't aggregate "holes" in an efficient way, as empty text nodes are inserted in between.

This might not even be a real-world performance issue, but it's something to think about, either here or in the specialized transformer, if even possible with ease.

P.S. right now everything looks fine and working as expected

@WebReflection WebReflection added the enhancement New feature or request label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant