error in build.sh script

[viewrock777]

Hello, you need add -p key to mkdir in your build.sh script, or he will not create parental directory and return No Such file or directory error. I try it in linux mint.

[viewrock777]

and the use of cp command is not very good. Can i suggest using the following option:
cp "`pwd`/icon.png" "`pwd`/startup.sh" ~/wol/Guitar_Pro_8
cp "`pwd`/guitarpro.desktop" $desktop

[NikoboiNFTB]

+1

user@pc:~$ mkdir ~/wol/Guitar_Pro_8
mkdir: cannot create directory ‘/home/ml/wol/Guitar_Pro_8’: No such file or directory
user@pc:~$ mkdir -p ~/wol/Guitar_Pro_8
user@pc:~$ ls ~/wol/
Guitar_Pro_8

On Debian, but it's the case in all distros that use mkdir.

---

And this is quite bad;

cp ~/wol/Downloads/Guitar_Pro_8/icon.png ~/wol/Downloads/Guitar_Pro_8/startup.sh ~/wol/Guitar_Pro_8
cp ~/wol/Downloads/Guitar_Pro_8/guitarpro.desktop $desktop

It just casually assumes that a folder exists; ~/wol/Downloads/Guitar_Pro_8 and why would it?

But this isn't perfect either;

cp "`pwd`/icon.png" "`pwd`/startup.sh" ~/wol/Guitar_Pro_8
cp "`pwd`/guitarpro.desktop" $desktop

It already uses wget for the install .exe, which is ~1Gb, so why not use it for these few Kb files?

desktop=$(xdg-user-dir DESKTOP)
# Alternatively, I'd use: DESKTOP="$HOME/Desktop"

# Download the files
wget -O ~/wol/Guitar_Pro_8/icon.png https://github.com/Windows-On-Linux/Guitar-Pro-On-Linux/raw/refs/heads/main/icon.png
wget -O ~/wol/Guitar_Pro_8/startup.sh https://github.com/Windows-On-Linux/Guitar-Pro-On-Linux/raw/refs/heads/main/startup.sh
wget -O "$desktop/guitarpro.desktop" https://github.com/Windows-On-Linux/Guitar-Pro-On-Linux/raw/refs/heads/main/guitarpro.desktop

I'd go as far as to;

wget -qO "$HOME/wol/Guitar_Pro_8/icon.png" "https://github.com/Windows-On-Linux/Guitar-Pro-On-Linux/raw/refs/heads/main/icon.png" &
wget -qO "$HOME/wol/Guitar_Pro_8/startup.sh" "https://github.com/Windows-On-Linux/Guitar-Pro-On-Linux/raw/refs/heads/main/startup.sh" &
wget -qO "$HOME/Desktop/guitarpro.desktop" "https://github.com/Windows-On-Linux/Guitar-Pro-On-Linux/raw/refs/heads/main/guitarpro.desktop" &
wait

This runs all downloads in parallel, quietly.