Merge pull request #7 from workflowai/guillaume/fix-types-enable-ruff

Fix types enable ruff

Author: guillaq

.github/workflows/publish.yml

@@ -21,6 +21,15 @@ jobs:
         run: |
           poetry config virtualenvs.in-project true
           poetry install --all-extras
+        
+      - name: Check package version matches tag
+        run: |
+          TAG_VERSION=${GITHUB_REF#refs/tags/v}
+          PACKAGE_VERSION=$(poetry version -s)
+          if [ "$TAG_VERSION" != "$PACKAGE_VERSION" ]; then
+            echo "Error: Tag version ($TAG_VERSION) does not match package version ($PACKAGE_VERSION)"
+            exit 1
+          fi
 
       - name: Build Python package
         run: poetry build

examples/__init__.py

@@ -12,7 +12,7 @@ class CityToCapitalTaskInput(BaseModel):
 
 class CityToCapitalTaskOutput(BaseModel):
     capital: str = Field(
-        description="The capital of the specified city", examples=["Tokyo"]
+        description="The capital of the specified city", examples=["Tokyo"],
     )
 
 

examples/city_to_capital_task.py

@@ -7,11 +7,11 @@
 from examples.city_to_capital_task import CityToCapitalTask, CityToCapitalTaskInput
 
 
-def main(city: str):
+def main(city: str) -> None:
     client = workflowai.start()
     task = CityToCapitalTask()
 
-    async def _inner():
+    async def _inner() -> None:
         task_input = CityToCapitalTaskInput(city=city)
         task_run = await client.run(task, task_input)
 

examples/run_task.py

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "workflowai"
-version = "0.1.3"
+version = "0.2.0"
 description = ""
 authors = ["Guillaume Aquilina <guillaume@workflowai.com>"]
 readme = "README.md"
@@ -14,10 +14,10 @@ typer = { version = "^0.12.3", optional = true }
 rich = { version = "^13.7.1", optional = true }
 
 [tool.poetry.group.dev.dependencies]
-pyright = "^1.1.367"
+pyright = "^1.1.381"
 pytest = "^8.2.2"
 pytest-asyncio = "^0.23.7"
-ruff = "^0.4.9"
+ruff = "^0.5.0"
 freezegun = "^1.5.1"
 pre-commit = "^3.7.1"
 pytest-httpx = "^0.30.0"
@@ -29,13 +29,30 @@ cli = ["typer", "rich"]
 [tool.poetry.scripts]
 workflowai = "workflowai.cli.main:main"
 
+[tool.ruff]
+line-length = 120
+
 [tool.ruff.lint]
-# Enable Pyflakes (`F`) and a subset of the pycodestyle (`E`)  codes by default.
-# Unlike Flake8, Ruff doesn't enable pycodestyle warnings (`W`) or
-# McCabe complexity (`C901`) by default.
-# TODO: enable C901 and other rules about documentation
-select = ["E4", "E7", "E9", "F", "T201", "TID251"]
-ignore = []
+select = ["ALL"]
+
+ignore = [
+    "D",
+    "PLC",
+    "FA",
+    "TRY",
+    "ANN",
+    "RET504",
+    "TCH",
+    "PTH",
+    "PLR",
+    "EM101",
+    "EM102",
+    "FBT001",
+    "FBT002",
+    "TD",
+    "PYI051",
+    "FIX002",
+]
 
 # Allow fix for all enabled rules (when `--fix`) is provided.
 fixable = ["ALL"]
@@ -44,6 +61,7 @@ unfixable = []
 [tool.ruff.lint.per-file-ignores]
 # in bin we use rich.print
 "bin/*" = ["T201"]
+"*_test.py" = ["S101"]
 
 [tool.pyright]
 pythonVersion = "3.9"

poetry.lock

@@ -28,14 +28,14 @@ async def test_deploy_task(wai: workflowai.Client):
 
     # Run using the environment and the same input
     task_run2 = await wai.run(
-        task, task_input=CityToCapitalTaskInput(city="Osaka"), environment="dev"
+        task, task_input=CityToCapitalTaskInput(city="Osaka"), environment="dev",
     )
     # IDs will match since we are using cache
     assert task_run.id == task_run2.id
 
     # Run using the environment and a different input
     task_run3 = await wai.run(
-        task, task_input=CityToCapitalTaskInput(city="Toulouse"), environment="dev"
+        task, task_input=CityToCapitalTaskInput(city="Toulouse"), environment="dev",
     )
     assert task_run3.task_output.capital == "Paris"
     assert task_run3.id != task_run2.id