Merge branch 'main' into add/reorder-apps

Author: addrian-77

.github/workflows/issue-builder.yml

@@ -170,10 +170,10 @@ jobs:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           UPSTREAM: "tock/tock"
           DOWNSTREAM: ${{ github.repository }}
-          TITLE: Bring updates from 'tock-tbf' to 'tbf-parser'
+          TITLE: Bring updates from `tock-tbf` to `tbf-parser`
           LABELS: D3-TBF PARSER,P1-CRITICAL,EXCLUSIVE LABEL
           BODY: |
-            Please review the commits in order of oldest to newest (bottom to top). Once you have implemented the corresponding updates, copy-paste the sha of the commit you last covered in ['.lastcommsha'](https://github.com/WyliodrinEmbeddedIoT/tockloader-rs/tree/main/.github/.lastcommsha). Make sure to label any PRs addressing the commits in this list with 'EXCLUSIVE LABEL'. The following commits need to be accounted for:
+            Please review the commits in order of oldest to newest (bottom to top). Once you have implemented the corresponding updates, copy-paste the sha of the commit you last covered in [.lastcommsha](https://github.com/WyliodrinEmbeddedIoT/tockloader-rs/tree/main/.github/.lastcommsha). Make sure to label any PRs addressing the commits in this list with `EXCLUSIVE LABEL`. The following commits need to be accounted for:
           PINNED: false
           CLOSE_PREVIOUS: true
 

.lastcommsha

@@ -143,7 +143,7 @@ impl AppAttributes {
             // The end of the application binary marks the beginning of the
             // footer.
             //
-            // TODO(george-cosma): This is not always true, `get_binary_end`
+            // Note: This is not always true, `get_binary_end`
             // does not make sense if the application is just padding. This can
             // crash the process.
             let binary_end_offset = header.get_binary_end();

tockloader-lib/src/attributes/app_attributes.rs

@@ -0,0 +1,25 @@
+use async_trait::async_trait;
+
+use crate::board_settings::BoardSettings;
+use crate::bootloader_serial::{
+    issue_command, ping_bootloader_and_wait_for_response, Command, Response,
+};
+use crate::connection::{Connection, SerialConnection};
+use crate::errors::{InternalError, TockloaderError};
+use crate::CommandEraseApps;
+
+#[async_trait]
+impl CommandEraseApps for SerialConnection {
+    async fn erase_apps(&mut self, settings: &BoardSettings) -> Result<(), TockloaderError> {
+        if !self.is_open() {
+            return Err(InternalError::ConnectionNotOpen.into());
+        }
+        let stream = self.stream.as_mut().expect("Board must be open");
+
+        ping_bootloader_and_wait_for_response(stream).await?;
+
+        let pkt = (settings.start_address as u32).to_le_bytes().to_vec();
+        let (_, _) = issue_command(stream, Command::ErasePage, pkt, true, 0, Response::OK).await?;
+        Ok(())
+    }
+}