Adjustable MIDI Volume

[OpenRift412]

Don't know if this has been addressed since the last release, but it would be nice to have some functionality in the MIDI volume adjustment, it's just kind of annoying that it doesn't work.

[Xenoveritas]

There is a music volume control already. Is it not working for you? And if not, what platform? Or do you mean volume isn't saved between launches? (Which I think was technically a behavior from the original game but worth fixing anyway.)

[OpenRift412]

There is a music volume control already. Is it not working for you? And if not, what platform? Or do you mean volume isn't saved between launches? (Which I think was technically a behavior from the original game but worth fixing anyway.)

I'd like to check this in the recent build, but there doesn't seem to be any pre-compiled binaries. Could you perhaps provide one?

[Xenoveritas]

There are Windows binary builds, they (should) work on other people's systems. (The one caveat with that should is that there's a good chance they're dynamically linking to the MSVCRT and you may need to have the exact MSVCRT DLL installed that I do to actually use the binaries. Although knowing this would also be helpful.) I would strongly recommend the ZIP version, I'm not sure Windows will let you install the MSI because it's not signed.

At some point I'd also like to provide macOS binaries but the current CPack configuration doesn't work on macOS. (It produces something, but the something is missing the actual executable binary for some reason.)

[OpenRift412]

There are Windows binary builds, they (should) work on other people's systems. (The one caveat with that should is that there's a good chance they're dynamically linking to the MSVCRT and you may need to have the exact MSVCRT DLL installed that I do to actually use the binaries. Although knowing this would also be helpful.) I would strongly recommend the ZIP version, I'm not sure Windows will let you install the MSI because it's not signed.

At some point I'd also like to provide macOS binaries but the current CPack configuration doesn't work on macOS. (It produces something, but the something is missing the actual executable binary for some reason.)

Ah, I see them now. They weren't there yesterday when I checked.

So testing it now, the MIDI volume sort of works, but the problem I've found is that the different tracks/instruments aren't adjusting in volume very consistently. I'm using Coolsoft MIDI Mapper to output to an external MIDI module (Roland SC-55ST), if you're not noticing any issues like this on your end, I would recommend testing with a custom Soundfont via VirtualMIDISynth, as I've seen in certain programs (like Chocolate Doom 3.0.0 and earlier) that MIDI volume will work fine with the default GS Wavetable MIDI Synth, but using any other MIDI device has volume issues. And I know for a fact that this isn't a problem with my setup because most other programs that will use MIDI work fine.

Sorry for the rambling, just thought I'd add the extra info to pre-emptively answer any questions you might have.

As for the volume being saved between launches, that would be a good thing to implement, I think.

[Xenoveritas]

Hm, if this also happens in Chocolate Doom, I wonder if it's actually a bug within SDL2_mixer, which both use as the interface to MIDI devices. Although if Chocolate Doom fixed it, there may be a clue somewhere as to what causes it.

[OpenRift412]

Hm, if this also happens in Chocolate Doom, I wonder if it's actually a bug within SDL2_mixer, which both use as the interface to MIDI devices. Although if Chocolate Doom fixed it, there may be a clue somewhere as to what causes it.

It's been fixed in Choco for a while, but if you want a truly up to date build then you'll need to check out the autobuilds.