Feature Menu takes too long to load and can cause missclick

[danielwerg]

Describe the bug

Feature Menu button takes too long to load and can cause user to missclick on Start Segment Now SponsorBlock button

To Reproduce
Steps to reproduce the behavior:

1. Open any video
2. Click on Increase Speed button 3-5 times
3. Feature Menu button appears and pushes Start Segment Now SponsorBlock button
4. User missclicks on Start Segment Now SponsorBlock button

Expected behavior

load all extension buttons at the same time

Screenshots

yt-enhancer.mp4

Desktop (please complete the following information):

• OS: Artix Linux
• Browser: librewolf 147.0.3
• Version: 4784d1b

Additional context

SponsorBlock collision

[VampireChicken12]

@danielwerg thank you for reporting, this is more of an overall issue some improvements to code needs to be done. Some of the buttons take a while to appear. I need to improve the logic behind it, I think this is part of the cause

[danielwerg]

this can be closed if #599 or #1184 is implemented. Increase Speed button is the only one i can imagine pressing right after opening video.

[VampireChicken12]

this can be closed if #599 or #1184 is implemented. Increase Speed button is the only one i can imagine pressing right after opening video.

even if that gets implemented I'd like to improve the core functionality

[VampireChicken12]

@danielwerg I haven’t started working on resolving the core issue, but I did think of something. Maybe I could make the code ensure all the buttons are inserted before the sponsor block buttons to prevent the shift.

[danielwerg]

yeah, i think having all the extension's buttons together would be a welcome change. but that means i would missclick on Feature Menu button instead, which still an improvement in my exact use case tbf.

i do want to note that i think it make sense to order Feature Menu button last, for ltr language speakers at least.

Decrease Speed, Increase Speed, Feature Menu, SponsorBlock, yt buttons...

[VampireChicken12]

Right not the feature menu button is just put right after the YouTube settings button.

[VampireChicken12]

Also the buttons have no specific ordering ltr or rtl isn't considered when placing them.