Check for ownership

[RICE0707]

#1371 @daniel-skopek

I believe that /res give should also have this restriction.
Otherwise, a VIP player could give their large Residence to a non-VIP player, allowing the non-VIP to obtain a Residence that exceeds their allowed size limit.

[daniel-skopek]

I will look into this

[daniel-skopek]

The owner of the residence can still give the residence to another player, thereby circumventing the limit, as they will be able to create a large residence of their own again.

I recommend adding a negative permission to players: residence.command.give

[RICE0707]

I don’t want to restrict players from using this feature through permissions.
What I mean is that, just like what you did in #1371, there should also be a check when executing /res give to ensure that non-VIP players cannot receive a Residence that exceeds their allowed size limit.

[daniel-skopek]

Yes, but the owner of the residence can still give them his residence and thus circumvent the limit.

[RICE0707]

No, that wouldn’t happen. If a check is implemented for /res give, the command execution can be blocked when necessary. Right now, this mechanism doesn’t exist, which is why I’m hoping it can be added.

[daniel-skopek]

The best solution would be to simply check, during /res give, whether the target player is allowed to own a residence of that size. If yes, proceed with the transfer. If not, block it.