From 0d5cd88be9609ec7888eafcf261c0a99a092222b Mon Sep 17 00:00:00 2001 From: nihar-aalyria <123415467+nihar-aalyria@users.noreply.github.com> Date: Wed, 18 Jun 2025 17:02:11 -0700 Subject: [PATCH] Revert "Commit 7c130ee" This PR reverts commit 7c130ee96e1ac003ce2b22ba51cedab1ca119598, which was accidentally submitted. Original MR description: Only check for the presence of apiSubDomain, i.e. "model", as opposed to apiSubDomain+".", i.e. "model.", when determining whether the URL needs to be modified. This allows URLs such as `model-v1alpha.{domain}` to be unmodified by this logic, which is the desired behavior. --- tools/nbictl/connection.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/nbictl/connection.go b/tools/nbictl/connection.go index efe5780..d20582f 100644 --- a/tools/nbictl/connection.go +++ b/tools/nbictl/connection.go @@ -64,7 +64,7 @@ func openAPIConnection(appCtx *cli.Context, apiSubDomain string) (*grpc.ClientCo func adjustURLForAPISubDomain(url string, apiSubDomain string) string { // Unexpectedly empty arguments or already the subdomain sought. - if url == "" || apiSubDomain == "" || strings.HasPrefix(url, apiSubDomain) { + if url == "" || apiSubDomain == "" || strings.HasPrefix(url, apiSubDomain+".") { return url }