From 3ef4cf3f94cf255ddb22a9474a14476b688258b6 Mon Sep 17 00:00:00 2001 From: Kate Davis Date: Tue, 13 Jul 2021 11:50:28 -0400 Subject: [PATCH 1/4] change seconds to minutes in createRoomForm --- frontend/components/CreateRoomForm.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/frontend/components/CreateRoomForm.js b/frontend/components/CreateRoomForm.js index c1bfbf6..2493a09 100644 --- a/frontend/components/CreateRoomForm.js +++ b/frontend/components/CreateRoomForm.js @@ -144,8 +144,7 @@ export default function CreateRoomForm() { type="number" placeholder="Time Limit" ref={createTimeLimit} - value={presetSelect ? presetSelect * 60 : ""} - // TODO: remove * 60 when we use minutes instead of seconds in the countdown + value={presetSelect ? presetSelect : ""} /> From 89440ac6f42cc9b6c345e45e5e8b79afe24dd8ee Mon Sep 17 00:00:00 2001 From: Kate Davis Date: Mon, 19 Jul 2021 10:43:35 -0400 Subject: [PATCH 2/4] add onChange handler to number input to have arrow buttons update time in state --- frontend/components/CreateRoomForm.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/frontend/components/CreateRoomForm.js b/frontend/components/CreateRoomForm.js index 2493a09..0d5ab34 100644 --- a/frontend/components/CreateRoomForm.js +++ b/frontend/components/CreateRoomForm.js @@ -92,6 +92,11 @@ export default function CreateRoomForm() { console.log(time); }; + const handleTimeLimitChange = (e) => { + console.log("time limit change value", e.target.value) + setPresetSelect(e.target.value) + }; + return ( {created ? ( @@ -145,6 +150,7 @@ export default function CreateRoomForm() { placeholder="Time Limit" ref={createTimeLimit} value={presetSelect ? presetSelect : ""} + onChange={handleTimeLimitChange} /> From 4e57bf649aa20c1f8b8fef0d3f3d03ae112e4e24 Mon Sep 17 00:00:00 2001 From: Kate Davis Date: Mon, 19 Jul 2021 11:08:10 -0400 Subject: [PATCH 3/4] set min and max on input type number --- frontend/components/CreateRoomForm.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/components/CreateRoomForm.js b/frontend/components/CreateRoomForm.js index 0d5ab34..7c50921 100644 --- a/frontend/components/CreateRoomForm.js +++ b/frontend/components/CreateRoomForm.js @@ -89,13 +89,11 @@ export default function CreateRoomForm() { const handlePresetTime = (time) => { setPresetSelect(time); - console.log(time); }; const handleTimeLimitChange = (e) => { - console.log("time limit change value", e.target.value) - setPresetSelect(e.target.value) - }; + setPresetSelect(e.target.value) + } return ( @@ -150,8 +148,10 @@ export default function CreateRoomForm() { placeholder="Time Limit" ref={createTimeLimit} value={presetSelect ? presetSelect : ""} + min={0} + max={15} onChange={handleTimeLimitChange} - /> + /> From 8e7cdbf86629276b83f3eb2414b4e7f192661dc9 Mon Sep 17 00:00:00 2001 From: Kate Davis Date: Mon, 19 Jul 2021 11:09:20 -0400 Subject: [PATCH 4/4] linting --- frontend/components/CreateRoomForm.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/components/CreateRoomForm.js b/frontend/components/CreateRoomForm.js index 7c50921..304103d 100644 --- a/frontend/components/CreateRoomForm.js +++ b/frontend/components/CreateRoomForm.js @@ -92,8 +92,8 @@ export default function CreateRoomForm() { }; const handleTimeLimitChange = (e) => { - setPresetSelect(e.target.value) - } + setPresetSelect(e.target.value); + }; return (