Skip to content

fix: flashloan disabled guard for debt-swap and repay + do not allow permit for SC wallets #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgrabina wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −6
Open

fix: flashloan disabled guard for debt-swap and repay + do not allow permit for SC wallets #2797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc77098
fix: check correct reserve for flashloan enabled on debt and repay
mgrabina Dec 4, 2025
c310ac4
fix: do not allow permit for sc wallets
mgrabina Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/transactions/Swap/actions/approval/useSwapTokenApproval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { defaultAbiCoder, splitSignature } from 'ethers/lib/utils';
import { Dispatch, useEffect, useMemo, useRef, useState } from 'react';
import { MOCK_SIGNED_HASH } from 'src/helpers/useTransactionHandler';
import { calculateSignedAmount } from 'src/hooks/paraswap/common';
import { useGetConnectedWalletType } from 'src/hooks/useGetConnectedWalletType';
import { useModalContext } from 'src/hooks/useModal';
import { useWeb3Context } from 'src/libs/hooks/useWeb3Context';
import { useRootStore } from 'src/store/root';
Expand Down Expand Up @@ -104,6 +105,8 @@ export const useSwapTokenApproval = ({
const { sendTx, signTxData } = useWeb3Context();
const [loadingPermitData, setLoadingPermitData] = useState(true);

const { isSmartContractWallet } = useGetConnectedWalletType();

const [
user,
generateApproval,
Expand Down Expand Up @@ -256,7 +259,7 @@ export const useSwapTokenApproval = ({
};
}, [chainId, token]);

const tryPermit = allowPermit && permitSupported === true;
const tryPermit = allowPermit && permitSupported === true && !isSmartContractWallet;
const usePermit = tryPermit && walletApprovalMethodPreference === ApprovalMethod.PERMIT;

const approval = async () => {
Expand Down
11 changes: 6 additions & 5 deletions src/components/transactions/Swap/errors/shared/FlashLoanDisabledBlockingGuard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ export const hasFlashLoanDisabled = (state: SwapState): boolean => {
return false;
}

if (
state.useFlashloan === true &&
state.sourceReserve?.reserve &&
!state.sourceReserve.reserve.flashLoanEnabled
) {
const reserve = !state.isInvertedSwap
? state.sourceReserve?.reserve
: state.destinationReserve?.reserve;

if (state.useFlashloan === true && reserve && !reserve.flashLoanEnabled) {
return true;
}

Expand Down Expand Up @@ -70,6 +70,7 @@ export const FlashLoanDisabledBlockingGuard = ({
state.provider,
state.useFlashloan,
state.sourceReserve?.reserve?.flashLoanEnabled,
state.destinationReserve?.reserve?.flashLoanEnabled,
state.error,
]);

Expand Down
Loading