diff --git a/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java b/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java index 706537d731bf..f01e3b914ac0 100644 --- a/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java +++ b/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java @@ -975,36 +975,6 @@ protected void sendExceededBackupLimitAlert(String ownerUuid, Resource.ResourceT message, message + " Please, use the 'updateResourceLimit' API to increase the backup limit."); } - public List listBackupSchedules(ListBackupScheduleCmd cmd) { - Account caller = CallContext.current().getCallingAccount(); - Long id = cmd.getId(); - Long vmId = cmd.getVmId(); - - if (vmId != null) { - final VMInstanceVO vm = findVmById(vmId); - validateBackupForZone(vm.getDataCenterId()); - accountManager.checkAccess(CallContext.current().getCallingAccount(), null, true, vm); - } - - Filter searchFilter = new Filter(BackupScheduleVO.class, "id", true, null, null); - SearchBuilder searchBuilder = backupScheduleDao.createSearchBuilder(); - searchBuilder.and("id", searchBuilder.entity().getId(), SearchCriteria.Op.EQ); - if (vmId != null) { - searchBuilder.and("vmId", searchBuilder.entity().getVmId(), SearchCriteria.Op.EQ); - } - - SearchCriteria sc = searchBuilder.create(); - if (id != null) { - sc.setParameters("id", id); - } - if (vmId != null) { - sc.setParameters("vmId", vmId); - } - - Pair, Integer> result = backupScheduleDao.searchAndCount(sc, searchFilter); - return new ArrayList<>(result.first()); - } - /** * Gets the backup schedule ID from the async job's payload. * diff --git a/server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java b/server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java index a838ed62d06f..7254a67d8bd6 100644 --- a/server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java +++ b/server/src/main/java/org/apache/cloudstack/vm/ImportVmTasksManagerImpl.java @@ -379,7 +379,7 @@ private void updateTaskDescriptionWithV2KStatus(ImportVMTaskResponse response, I } private void cleanupAblestackV2KDomain(ImportVMTaskVO task) { - if (task == null || task.getConvertHostId() == null || StringUtils.isBlank(task.getSourceVMName())) { + if (task == null || task.getConvertHostId() <= 0 || StringUtils.isBlank(task.getSourceVMName())) { return; } HostVO convertHost = hostDao.findById(task.getConvertHostId()); diff --git a/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java b/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java index 6c5f373a8394..ca9d4b66f5e3 100644 --- a/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java +++ b/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java @@ -3958,7 +3958,7 @@ protected void cleanupAblestackV2KDomain(ImportVMTaskVO task, HostVO convertHost } protected void cleanupAblestackV2KDomain(ImportVMTaskVO task) { - if (task == null || task.getConvertHostId() == null) { + if (task == null || task.getConvertHostId() <= 0) { return; } HostVO convertHost = hostDao.findById(task.getConvertHostId()); diff --git a/ui/src/main.js b/ui/src/main.js index a5e11c8f1a32..7441f8010865 100644 --- a/ui/src/main.js +++ b/ui/src/main.js @@ -127,4 +127,4 @@ fetch('config.json?ts=' + Date.now()) }) }).catch(error => { renderError(error) - }) \ No newline at end of file + })