CI: Add msys2 UCRT64 and CLANGARM64 targets #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two new platform for cmake and regressions tests - MSYS2 clangarm64 (Windows on ARM64 runners) - MSYS2 UCRT64 (Windows Latest runner) On those platforms, systemc is built as a shared library. Signed-off-by: Jerome Haxhiaj <jhaxhiaj@qti.qualcomm.com>
aut0
reviewed
Nov 5, 2025
| install: git mingw-w64-clang-aarch64-clang mingw-w64-clang-aarch64-cmake mingw-w64-clang-aarch64-ninja | ||
| - name: CI-Build | ||
| run: | | ||
| ./msys2-ci-build.sh |
Contributor
There was a problem hiding this comment.
I don't think this script should be at the top level.
Maybe we should consider moving the docker/ folder into a ci/ folder and put everything there or introduce a utils/ folder where this kind of script can go.
| BUILD_SHARED_LIBS="ON" | ||
|
|
||
| SYSTEMC_CI_DEFAULT_TARGET="systemc" | ||
| SYSTEMC_CI_REGRESSION_TARGET="check-tests" |
Contributor
There was a problem hiding this comment.
The current docker entrypoint.sh does:
cmake
cmake --build
cmake --install
make ... check
Is this doing the same?
If so, I am in favor of unifying this accross workflows so that all CI flows use the same build targets.
| -D CMAKE_BUILD_TYPE=${BUILD_TYPE} \ | ||
| -D CMAKE_INSTALL_PREFIX="${INSTALL_DIR}" | ||
|
|
||
| # Build the project |
Contributor
There was a problem hiding this comment.
I think we can remove all comments (that point out obvious things) from this script.
| BUILD_DIR="build" | ||
| INSTALL_DIR="$(pwd)/install" | ||
| REGRESSION_TESTS="OFF" | ||
| BUILD_SHARED_LIBS="ON" |
Contributor
There was a problem hiding this comment.
It would be nice to test both, shared and static library flows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new platform for cmake and regressions tests
On those platforms, systemc is built as a shared library.