forked from abh1nash/ace-daw
-
Notifications
You must be signed in to change notification settings - Fork 7
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Problem
The TrackNodeSend.test.ts unit test is failing in CI on all PRs because it calls trackNode.updateSendPrePost(), a method that does not exist on TrackNode.
Error:
TypeError: trackNode.updateSendPrePost is not a function
Root Cause
When aux sends were implemented in PR #1039, the test was written against an initially planned API that used:
updateSendPrePost(id, 'pre' | 'post')— separate method for switching tap pointconnectSend(id, dest, amount, 'pre' | 'post')— string literals for pre/post
But the actual implementation uses:
updateSendAmount(id, amount, preFader: boolean)— combines amount + pre/post switchingconnectSend(id, dest, amount, preFader: boolean)— boolean parameter
The test was never updated to match the final API.
Impact
- 1 test failing across all PRs (blocks CI
unit-testjob) - 3475 other tests pass fine
Acceptance Criteria
-
updateSendPrePosttest updated to useupdateSendAmountwith correct boolean parameter - All
connectSendcalls in test usebooleaninstead of string'pre'/'post' - All 3476+ unit tests pass
- No changes to production code (test-only fix)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working