From 0ce4ea4abdb3e76d3e1cee5365a2aca7344b25dd Mon Sep 17 00:00:00 2001
From: gambinoxxx <ibehchristopher11@gmail.com>
Date: Mon, 27 Oct 2025 22:13:43 -0700
Subject: [PATCH] fix: Correct critical bugs and improve code quality

This commit addresses several critical bugs and improves the overall code quality in various game implementations within the repository.

- C++ Hangman Game (Hangman.cpp):
  - Resolved a critical buffer overflow that caused crashes by correctly sizing std::string variables before use.
  - Replaced unsafe C-style string loops with modern C++ std::string::length() checks for better safety and clarity.
  - Substituted the non-portable system("clear") with a cross-platform alternative for screen clearing.

- JavaScript Dodgeball Game (loginregister.html):
  - Fixed a bug where login and registration forms used duplicate HTML id's, causing incorrect element selection in JavaScript.
  - Added a security warning regarding the insecure practice of storing passwords in localStorage.

- JavaScript ConnectFour Game (registration.js):
  - Completed the showRankingsTable function, which was missing the logic to generate and display the rankings table from localStorage data.

These changes ensure the applications run more reliably and adhere to better coding and security practices.
---
 Languages/C++/Hangman.cpp                     | 26 +++++++++----------
 .../ConnectFour Game/registration.js          |  6 +++--
 .../Javascript/Dodgeball/loginregister.html   | 12 ++++-----
 3 files changed, 23 insertions(+), 21 deletions(-)

diff --git a/Languages/C++/Hangman.cpp b/Languages/C++/Hangman.cpp
index 6cb4df6d..dc3643c2 100644
--- a/Languages/C++/Hangman.cpp
+++ b/Languages/C++/Hangman.cpp
@@ -25,19 +25,19 @@ int main()
 	cout<<"Player's 1 turn.Player 1 needs to enter word-";
 	getline(cin,word);  //Input String
 	cout<<word<<endl;;
-	cout<<"Enter hint for Player 2-";
-	getline(cin,hint);
-	cout<<hint<<endl;
-	for(i=0;word[i]!='&#092;&#048;';i++)
+    cout<<"Enter hint for Player 2-";
+    getline(cin,hint);
+    cout<<hint<<endl;
+	for(i=0; i < word.length(); i++)
 		word[i]=toupper(word[i]); //Convert the input String into uppercase
 
 
-	system("clear"); // Clear the entered string
+	cout << string(50, '\n'); // Clear the screen in a portable way
 	cout<<"\nNow It is time for Player 2 to guess ";
 
-	for(i=0;word[i]!='&#092;&#048;';i++)
+	duplicate.resize(word.length(), '-'); // Properly size the duplicate string
+	for(i=0; i < word.length(); i++)
 	{	cout<<"-" ; //Convert the input String into dashes
-	    duplicate[i]='-';
 	}
 
 	cout<<"\n\n";
@@ -59,9 +59,9 @@ int main()
 			cin>>letter;
 			letter=toupper(letter); // Convert into Upper case
 			cout<<letter<<endl;
-			used[number]=letter;// To show used letters
+			used += letter; // Append used letter to the string
 
-			for(i=0;word[i]!='&#092;&#048;';i++)
+			for(i=0; i < word.length(); i++)
 				if(word[i]==letter) // To check whether character is present
 				{
 					duplicate[i]=word[i];
@@ -82,8 +82,8 @@ int main()
 				cout<<endl;
 			}
 			cout<<"Letter used\n";
-			for(int f=1;f<=number;f++)
-				cout<<used[f]<<","; //To display used letters
+			for(char used_char : used)
+				cout << used_char << ","; //To display used letters
 			cout<<endl<<endl;
 			if(chances==0)
 			{
@@ -95,8 +95,8 @@ int main()
 		{
 			cout<<"Enter word-";
 		    cin>>guess;
-			cout<<guess<<endl;
-			for(i=0;guess[i]!='&#092;&#048;';i++)
+            cout<<guess<<endl;
+			for(i=0; i < guess.length(); i++)
 		        guess[i]=toupper(guess[i]); //Convert the input String into uppercase
 
 			int x = word.compare(guess); // 0 if strings are same
diff --git a/Languages/Javascript/ConnectFour Game/registration.js b/Languages/Javascript/ConnectFour Game/registration.js
index 811fb028..5c5bff58 100644
--- a/Languages/Javascript/ConnectFour Game/registration.js	
+++ b/Languages/Javascript/ConnectFour Game/registration.js	
@@ -119,17 +119,19 @@
                 //All of the keys should point to user data except loggedInUser
                 if(key !== "loggedInUser"){
                     //Extract object containing user data
+                    var usrObj = JSON.parse(localStorage[key]);
 
                     //Extract user name and top score
-                    htmlStr += "David";
+                    htmlStr += "<tr><td>" + usrObj.username + "</td><td>" + usrObj.topscore + "</td></tr>";
                     //Add a table row to the HTML string.
                 }
             }
            
             //Finish off the table
             htmlStr += "</table>";
-           
+
             //Add the table to the page.
+            rankingDiv.innerHTML = htmlStr;
 
         }
     
\ No newline at end of file
diff --git a/Languages/Javascript/Dodgeball/loginregister.html b/Languages/Javascript/Dodgeball/loginregister.html
index 571aa026..dfd5f5d9 100644
--- a/Languages/Javascript/Dodgeball/loginregister.html
+++ b/Languages/Javascript/Dodgeball/loginregister.html
@@ -63,10 +63,10 @@ <h1>Login</h1>
         <script>
         
         // Does some basic checking of user data then stores user data in localStorage
+        // WARNING: Storing passwords in localStorage is not secure. This is for demonstration only.
         function registerUser(){
             
             var usrObject = {};
-
             //Extract the name and password that the user has entered
             usrObject.registername = document.getElementById("registername").value;
             usrObject.registerpassword = document.getElementById("registerpassword").value;
@@ -79,23 +79,23 @@ <h1>Login</h1>
         }
             
         function checkLogin(){ //extract details of logged in user
-            if(localStorage.loggedInUsrEmail !-- undefined){
-                var usrObj = JSON.parse(localStorage[localStorage.loggedinUsrEmail]);
+            if(localStorage.loggedInUsrEmail !== undefined){
+                var usrObj = JSON.parse(localStorage.getItem(localStorage.loggedInUsrEmail));
                 document.getElementById("loginPara").innerHTML = usrObj.registername + "logged in."; //greet logged in user
             }
             
         }
         
         function login(){
-            var email = document.getElementById("registeremail").value; //get email address
-            
+            var email = document.querySelector("#loginPara #registeremail").value; //get email address from login form
+
             if(localStorage[email] === undefined) { //users that dont have account
                 document.getElementById("loginFailure").innerHTML = "Email not recognised. Do you have an account?"; //inform failure to user
                 return;
             }
             else{
                 var usrObj = JSON.parse(localStorage[email]); //convert to object
-                var password = document.getElementById("registerpassword").value;
+                var password = document.querySelector("#loginPara #registerpassword").value;
                 if (password === usrObj.registerpassword){ //successful login
                     document.getElementById("loginPara").innerHTML = usrObj.registername + "logged in.";
                     document.getElementById("loginFailure").innerHTML = ""; // clear login failures