Merge pull request #2374 from njhale/fix-job-service-names

Remove -job suffix from generated service names

Author: njhale

pkg/controller/appdefinition/testdata/computeclass/job/expected.golden

@@ -153,7 +153,7 @@ metadata:
     acorn.io/job-name: oneimage
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.oneimage
-  name: oneimage-job
+  name: oneimage
   namespace: app-created-namespace
 spec:
   appName: app-name

pkg/controller/appdefinition/testdata/deployspec/filter-user-labels/expected.golden

@@ -303,7 +303,7 @@ metadata:
     acorn.io/job-name: job-name
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.job-name
-  name: job-name-job
+  name: job-name
   namespace: app-created-namespace
 spec:
   annotations:

pkg/controller/appdefinition/testdata/deployspec/labels/expected.golden

@@ -297,7 +297,7 @@ metadata:
     acorn.io/job-name: job-name
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.job-name
-  name: job-name-job
+  name: job-name
   namespace: app-created-namespace
 spec:
   annotations:

pkg/controller/appdefinition/testdata/deployspec/no-user-labels/expected.golden

@@ -239,7 +239,7 @@ metadata:
     acorn.io/job-name: job-name
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.job-name
-  name: job-name-job
+  name: job-name
   namespace: app-created-namespace
 spec:
   appName: app-name

pkg/controller/appdefinition/testdata/deployspec/pre-stop/job/expected.golden

@@ -134,7 +134,7 @@ metadata:
     acorn.io/job-name: oneimage
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.oneimage
-  name: oneimage-job
+  name: oneimage
   namespace: app-created-namespace
 spec:
   appName: app-name

pkg/controller/appdefinition/testdata/job/basic/expected.golden

@@ -134,7 +134,7 @@ metadata:
     acorn.io/job-name: oneimage
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.oneimage
-  name: oneimage-job
+  name: oneimage
   namespace: app-created-namespace
 spec:
   appName: app-name

pkg/controller/appdefinition/testdata/job/labels/expected.golden

@@ -149,7 +149,7 @@ metadata:
     acorn.io/job-name: job1
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.job1
-  name: job1-job
+  name: job1
   namespace: app-created-namespace
 spec:
   annotations:

pkg/controller/appdefinition/testdata/memory/job/expected.golden

@@ -138,7 +138,7 @@ metadata:
     acorn.io/job-name: oneimage
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.oneimage
-  name: oneimage-job
+  name: oneimage
   namespace: app-created-namespace
 spec:
   appName: app-name

pkg/controller/appdefinition/testdata/permissions/both/expected.golden

@@ -493,7 +493,7 @@ metadata:
     acorn.io/job-name: oneimage
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.oneimage
-  name: oneimage-job
+  name: oneimage
   namespace: app-created-namespace
 spec:
   appName: app-name

pkg/controller/appdefinition/testdata/permissions/bothwithnopermissions/expected.golden

@@ -295,7 +295,7 @@ metadata:
     acorn.io/job-name: oneimage
     acorn.io/managed: "true"
     acorn.io/public-name: app-name.oneimage
-  name: oneimage-job
+  name: oneimage
   namespace: app-created-namespace
 spec:
   appName: app-name