Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Commit 2d44729

Browse files
authored
Merge pull request #2225 from tylerslaton/no-job-compute
Don't add compute for Jobs to QuotaRequestInstances
2 parents 27d58f9 + d23cd50 commit 2d44729

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pkg/controller/quota/quota.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,11 @@ func EnsureQuotaRequest(req router.Request, resp router.Response) error {
9494
// Add the more complex values to the quota request
9595
addContainers(app.Containers, quotaRequest)
9696
addCompute(app.Containers, appInstance, quotaRequest)
97-
addCompute(app.Jobs, appInstance, quotaRequest)
97+
// TODO: This is a stop-gap until we figure out how to handle the compute resources of
98+
// jobs. The problem is that Jobs are not always running, so we can't just add
99+
// their compute resources to the quota request permananetly. To some degree it'll
100+
// have to be dynamic, but we can't do that until we have a better idea of how.
101+
// addCompute(app.Jobs, appInstance, quotaRequest)
98102
if err := addStorage(appInstance, quotaRequest); err != nil {
99103
status.Error(err)
100104
return err

0 commit comments

Comments
 (0)