Merge pull request #936 from iwilltry42/iwilltry42/issue915

cjellick · web-flow · commit 55504a615482 · 2022-11-28T09:46:51.000-07:00
fix: do not skip validation if image didn't change
diff --git a/pkg/server/registry/apps/strategy.go b/pkg/server/registry/apps/strategy.go
@@ -90,10 +90,7 @@ func (s *Strategy) Validate(ctx context.Context, obj runtime.Object) (result fie
 }
 
 func (s *Strategy) ValidateUpdate(ctx context.Context, obj, old runtime.Object) (result field.ErrorList) {
-	oldParams, newParams := old.(*apiv1.App), obj.(*apiv1.App)
-	if oldParams.Spec.Image == newParams.Spec.Image {
-		return nil
-	}
+	newParams := obj.(*apiv1.App)
 	return s.Validate(ctx, newParams)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -90,10 +90,7 @@ func (s *Strategy) Validate(ctx context.Context, obj runtime.Object) (result fie`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`func (s *Strategy) ValidateUpdate(ctx context.Context, obj, old runtime.Object) (result field.ErrorList) {`
`93`		`- oldParams, newParams := old.(apiv1.App), obj.(apiv1.App)`
`94`		`- if oldParams.Spec.Image == newParams.Spec.Image {`
`95`		`- return nil`
`96`		`- }`
	`93`	`+ newParams := obj.(*apiv1.App)`
`97`	`94`	`return s.Validate(ctx, newParams)`
`98`	`95`	`}`
`99`	`96`