[bug] V6 Upload progress stalled behind proxy while V5 works

[nihui]

What happened?

V6 breaks uploading behind proxy on self-hosted runner
after reverting to V5, it works

What did you expect to happen?

V6 shall use proxy settings

How can we reproduce it?

V6 https://github.com/Tencent/ncnn/actions/runs/20455804174/job/58778392875
reverted to V5 https://github.com/Tencent/ncnn/actions/runs/20456414421/job/58779448653

Anything else we need to know?

No response

What version of the action are you using?

2.330.0

What are your runner environments?

self-hosted

Are you on GitHub Enterprise Server? If so, what version?

No response

[Mark-Fulton]

Second this, Also using Self Hosted Runners. However I got a different type of error:

Run actions/upload-artifact@v6
With the provided path, there will be X files uploaded
Artifact name is valid!
Root directory input is valid!
Beginning upload of artifact content to blob storage
Error: Proxy connection ended before receiving CONNECT response

[chadhpaine]

Thirded, but again, a slightly different error message, this time not necessarily related to proxy - or maybe it is, it's not possible to tell what we're doing incorrectly since it works with v5:

With the provided path, there will be 200 files uploaded
Artifact name is valid!
Root directory input is valid!
Beginning upload of artifact content to blob storage
Error: Unable to make request: ECONNRESET
If you are using self-hosted runners, please make sure your runner has access to all GitHub endpoints: https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners#communication-between-self-hosted-runners-and-github

[zisuu]

We get weird HTTP 400 issues (also with the most recent version of the cache action). I made a tcpdump with v5 and v6 and compared them.

What I found out so far:

v5 does make proper CONNECT requests/handshake to the proxy before sending data:

CONNECT results-receiver.actions.githubusercontent.com:443 HTTP/1.1
Host: results-receiver.actions.githubusercontent.com:443
User-Agent: VSServices/2.330.0.0 (NetStandard; Ubuntu 24.04.3 LTS) ...
Connection: close

CONNECT productionresultssa0.blob.core.windows.net:443 HTTP/1.1
host: productionresultssa0.blob.core.windows.net:443
Connection: close

With v6, there is not a single CONNECT request. v6 tries to send data directly to the proxy without establishing CONNECT tunnels first, which is, from my point of view, why the requests fail.

Even if I explicitly use node version 24 and set the ENV var NODE_USE_ENV_PROXY: 1, there is no single CONNECT request in my tcpdump.