[bug] DeleteArtifact should not consider a 404 response an error #751
Description
What happened?
I am using actions/upload-artifact/merge@v6 with delete-merged to merge multiple artifacts.
In one run, a deletion request apparently encountered an error, but the artifact was nevertheless deleted. The retry then received a 404 in response, which was considered a fatal error and the job was aborted:
The 16 artifact(s) have been successfully merged!
Artifact 'redacted' (ID: 5112988597) deleted
Artifact 'redacted' (ID: 5112972671) deleted
Artifact 'redacted' (ID: 5112970291) deleted
Artifact 'redacted' (ID: 5112969022) deleted
Artifact 'redacted' (ID: 5112969635) deleted
Artifact 'redacted' (ID: 5112974831) deleted
Artifact 'redacted' (ID: 5112974586) deleted
Artifact 'redacted' (ID: 5112973778) deleted
Artifact 'redacted' (ID: 5112973622) deleted
Artifact 'redacted' (ID: 5112977891) deleted
Artifact 'redacted' (ID: 5112969221) deleted
Artifact 'redacted' (ID: 5112974763) deleted
Artifact 'redacted' (ID: 5112982251) deleted
Artifact 'redacted' (ID: 5112972191) deleted
Artifact 'redacted' (ID: 5112986641) deleted
Attempt 1 of 5 failed with error: Unexpected token '<', "<!DOCTYPE "... is not valid JSON. Retrying request in 3000 ms...
Error: Failed to DeleteArtifact: Received non-retryable error: Failed request: (404) Not Found: artifact not found
Since the delete-merged option is destructive, I also can't just retry the build, since the artifacts to merge no longer exist.
What did you expect to happen?
I expected the deletion to silently ignore a non-existing artifact, since a non-existing artifact already is the desired result.
How can we reproduce it?
This is probably not reproducible since it relies on a server error.
Anything else we need to know?
No response
What version of the action are you using?
actions/upload-artifact/merge@v6
What are your runner environments?
linux
Are you on GitHub Enterprise Server? If so, what version?
No response