From d3aebf34385deda116835426487ff8109b643ee5 Mon Sep 17 00:00:00 2001 From: Adam Wick Date: Thu, 12 Feb 2026 08:51:02 -0800 Subject: [PATCH 1/3] Fix a typo. --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index 6ed49ad..74d1aa8 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,4 +1,4 @@ -e[package] +[package] name = "simple_asn1" version = "0.6.3" authors = ["Adam Wick "] From fcecb99bdbebce45f0682a4c7b760d8191137af5 Mon Sep 17 00:00:00 2001 From: Adam Wick Date: Thu, 12 Feb 2026 08:54:09 -0800 Subject: [PATCH 2/3] Make clippy-clean. --- src/lib.rs | 42 ++++++++++++++++++++---------------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index 80afd71..2553430 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -153,33 +153,31 @@ impl PartialEq for ASN1Block { fn eq(&self, other: &ASN1Block) -> bool { match (self, other) { (&ASN1Block::Boolean(_, a1), &ASN1Block::Boolean(_, a2)) => a1 == a2, - (&ASN1Block::Integer(_, ref a1), &ASN1Block::Integer(_, ref a2)) => a1 == a2, + (ASN1Block::Integer(_, ref a1), ASN1Block::Integer(_, ref a2)) => a1 == a2, (&ASN1Block::BitString(_, a1, ref b1), &ASN1Block::BitString(_, a2, ref b2)) => { (a1 == a2) && (b1 == b2) } - (&ASN1Block::OctetString(_, ref a1), &ASN1Block::OctetString(_, ref a2)) => a1 == a2, - (&ASN1Block::Null(_), &ASN1Block::Null(_)) => true, - (&ASN1Block::ObjectIdentifier(_, ref a1), &ASN1Block::ObjectIdentifier(_, ref a2)) => { + (ASN1Block::OctetString(_, ref a1), ASN1Block::OctetString(_, ref a2)) => a1 == a2, + (ASN1Block::Null(_), &ASN1Block::Null(_)) => true, + (ASN1Block::ObjectIdentifier(_, ref a1), ASN1Block::ObjectIdentifier(_, ref a2)) => { a1 == a2 } - (&ASN1Block::UTF8String(_, ref a1), &ASN1Block::UTF8String(_, ref a2)) => a1 == a2, - (&ASN1Block::PrintableString(_, ref a1), &ASN1Block::PrintableString(_, ref a2)) => { + (ASN1Block::UTF8String(_, ref a1), ASN1Block::UTF8String(_, ref a2)) => a1 == a2, + (ASN1Block::PrintableString(_, ref a1), ASN1Block::PrintableString(_, ref a2)) => { a1 == a2 } - (&ASN1Block::TeletexString(_, ref a1), &ASN1Block::TeletexString(_, ref a2)) => { + (ASN1Block::TeletexString(_, ref a1), ASN1Block::TeletexString(_, ref a2)) => a1 == a2, + (ASN1Block::IA5String(_, ref a1), ASN1Block::IA5String(_, ref a2)) => a1 == a2, + (ASN1Block::UTCTime(_, ref a1), ASN1Block::UTCTime(_, ref a2)) => a1 == a2, + (ASN1Block::GeneralizedTime(_, ref a1), ASN1Block::GeneralizedTime(_, ref a2)) => { a1 == a2 } - (&ASN1Block::IA5String(_, ref a1), &ASN1Block::IA5String(_, ref a2)) => a1 == a2, - (&ASN1Block::UTCTime(_, ref a1), &ASN1Block::UTCTime(_, ref a2)) => a1 == a2, - (&ASN1Block::GeneralizedTime(_, ref a1), &ASN1Block::GeneralizedTime(_, ref a2)) => { + (ASN1Block::UniversalString(_, ref a1), ASN1Block::UniversalString(_, ref a2)) => { a1 == a2 } - (&ASN1Block::UniversalString(_, ref a1), &ASN1Block::UniversalString(_, ref a2)) => { - a1 == a2 - } - (&ASN1Block::BMPString(_, ref a1), &ASN1Block::BMPString(_, ref a2)) => a1 == a2, - (&ASN1Block::Sequence(_, ref a1), &ASN1Block::Sequence(_, ref a2)) => a1 == a2, - (&ASN1Block::Set(_, ref a1), &ASN1Block::Set(_, ref a2)) => a1 == a2, + (ASN1Block::BMPString(_, ref a1), ASN1Block::BMPString(_, ref a2)) => a1 == a2, + (ASN1Block::Sequence(_, ref a1), ASN1Block::Sequence(_, ref a2)) => a1 == a2, + (ASN1Block::Set(_, ref a1), ASN1Block::Set(_, ref a2)) => a1 == a2, ( &ASN1Block::Explicit(a1, _, ref b1, ref c1), &ASN1Block::Explicit(a2, _, ref b2, ref c2), @@ -206,7 +204,7 @@ impl OID { /// converts the pub fn as_raw(&self) -> Result, ASN1EncodeErr> { - match (self.0.get(0), self.0.get(1)) { + match (self.0.first(), self.0.get(1)) { (Some(v1), Some(v2)) => { let two = BigUint::from_u8(2).unwrap(); @@ -256,10 +254,10 @@ impl OID { } } -impl<'a> PartialEq for &'a OID { +impl PartialEq for &OID { fn eq(&self, v2: &OID) -> bool { - let &&OID(ref vec1) = self; - let &OID(ref vec2) = v2; + let OID(ref vec1) = self; + let OID(ref vec2) = v2; if vec1.len() != vec2.len() { return false; @@ -401,7 +399,7 @@ fn from_der_(i: &[u8], start_offset: usize) -> Result, ASN1Decode // BIT STRING Some(0x03) if body.is_empty() => result.push(ASN1Block::BitString(soff, 0, Vec::new())), Some(0x03) => { - let bits = (&body[1..]).to_vec(); + let bits = (body[1..]).to_vec(); let bitcount = bits.len() * 8; let rest = body[0] as usize; if bitcount < rest { @@ -741,7 +739,7 @@ pub fn to_der(i: &ASN1Block) -> Result, ASN1EncodeErr> { } // OBJECT IDENTIFIER ASN1Block::ObjectIdentifier(_, OID(ref nums)) => { - match (nums.get(0), nums.get(1)) { + match (nums.first(), nums.get(1)) { (Some(v1), Some(v2)) => { let two = BigUint::from_u8(2).unwrap(); From 9d5596d695e6bf2e82ea79a21836a4b59fdbf790 Mon Sep 17 00:00:00 2001 From: Adam Wick Date: Thu, 12 Feb 2026 08:54:27 -0800 Subject: [PATCH 3/3] 0.6.4 --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index 74d1aa8..364ef14 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "simple_asn1" -version = "0.6.3" +version = "0.6.4" authors = ["Adam Wick "] description = "A simple DER/ASN.1 encoding/decoding library." categories = ["encoding"]