diff --git a/Procfile b/Procfile new file mode 100644 index 000000000..62e430aca --- /dev/null +++ b/Procfile @@ -0,0 +1 @@ +web: gunicorn 'app:create_app()' \ No newline at end of file diff --git a/app/__init__.py b/app/__init__.py index 70b4cabfe..b984d3ddb 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -1,7 +1,32 @@ from flask import Flask +from flask_sqlalchemy import SQLAlchemy +from flask_migrate import Migrate +from dotenv import load_dotenv +import os +db = SQLAlchemy() +migrate = Migrate(compare_type=True) +load_dotenv() def create_app(test_config=None): app = Flask(__name__) + app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False + + if test_config: + app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get("SQLALCHEMY_TEST_DATABASE_URI") + app.config['TESTING'] = True + else: + app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get("SQLALCHEMY_DATABASE_URI") + + from app.models.planet import Planet + from app.models.moon import Moon + db.init_app(app) + migrate.init_app(app, db) + + from .routes.planets_routes import planets_bp + from .routes.moons_routes import moons_bp + app.register_blueprint(planets_bp) + app.register_blueprint(moons_bp) + return app diff --git a/app/models/__init__.py b/app/models/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/app/models/moon.py b/app/models/moon.py new file mode 100644 index 000000000..97b42c133 --- /dev/null +++ b/app/models/moon.py @@ -0,0 +1,44 @@ +from app import db + +class Moon(db.Model): + __tablename__ = 'moons' + id = db.Column(db.Integer, primary_key=True, autoincrement=True) + name = db.Column(db.String, nullable=False) + size = db.Column(db.Float, nullable=False) + description = db.Column(db.String, nullable=False) + discovery_date = db.Column(db.DateTime, nullable=False) + planet = db.relationship("Planet", back_populates="moons") + planet_id = db.Column(db.Integer, db.ForeignKey("planets.id")) + + @classmethod + def get_all_attrs(cls): + """ + Returns all existing attributes (list) in Planet class + """ + return [attr for attr in dir(cls) if callable(attr)] + + @classmethod + def from_dict(cls, dict, planet, planet_id): + return Moon( + name=dict["name"], + size=dict["size"], + description=dict["description"], + discovery_date=dict["discovery_date"], + planet=planet, + planet_id=planet_id, + ) + + def to_dict(self): + """ + Returns dictionary containing Planet instance data + """ + return { + "id": self.id, + "name": self.name, + "size": self.size, + "description": self.description, + "discovery_date": self.discovery_date, + "planet_id": self.planet_id, + #"planet": self.planet.name, + } + \ No newline at end of file diff --git a/app/models/planet.py b/app/models/planet.py new file mode 100644 index 000000000..b37161785 --- /dev/null +++ b/app/models/planet.py @@ -0,0 +1,37 @@ +from app import db + +class Planet(db.Model): + __tablename__ = 'planets' + id = db.Column(db.Integer, primary_key=True, autoincrement=True) + name = db.Column(db.String, nullable=False) + description = db.Column(db.String, nullable=False) + mass = db.Column(db.Float, nullable=False) + moons = db.relationship("Moon", back_populates="planet") + + @classmethod + def get_all_attrs(cls): + """ + Returns all existing attributes (list) in Planet class + """ + return [attr for attr in dir(Planet) if callable(attr)] + + @classmethod + def from_dict(cls, dict): + return Planet(name=dict["name"], + description=dict["description"], + mass=dict["mass"]) + + def to_dict(self): + """ + Returns dictionary containing Planet instance data + """ + return { + "id": self.id, + "name": self.name, + "description": self.description, + "mass": self.mass + } + # @classmethod + # def get_planet_by_id(cls, id): + # return cls.query.get(id) + \ No newline at end of file diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 8e9dfe684..000000000 --- a/app/routes.py +++ /dev/null @@ -1,2 +0,0 @@ -from flask import Blueprint - diff --git a/app/routes/__init__.py b/app/routes/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/app/routes/moons_routes.py b/app/routes/moons_routes.py new file mode 100644 index 000000000..68d0506be --- /dev/null +++ b/app/routes/moons_routes.py @@ -0,0 +1,42 @@ +from app import db +from flask import Blueprint, jsonify, abort, make_response, request +from ..models.moon import Moon +from ..models.planet import Planet +from app.routes.planets_routes import validate_model +moons_bp = Blueprint("moons", __name__, url_prefix = "/moons") + +# ~~~~~~ Planet Routes ~~~~~ +@moons_bp.route("", methods=["GET"]) +def display_all_moons(): + moons = Moon.query.all() + # fill http response + response_moons = [] + for moon in moons: + response_moons.append(moon.to_dict()) + return jsonify(response_moons) + +@moons_bp.route("/",methods=["GET"]) +def display_moon(moon_id): + moon = validate_model(Moon, moon_id) + return moon.to_dict() + + +@moons_bp.route("", methods=["POST"]) +def create_moon(): + request_body = request.get_json() + + #required request body: name, description, size, discovery_date, planet_id + attribute_requirements = ["name", "description", "size", "discovery_date", "planet_id"] + + for req in attribute_requirements: + if req not in request_body: + abort(make_response({ + "message" : f"Failed to create a planet because {req} missing" + }, 400)) + + planet_id = request_body["planet_id"] + planet = validate_model(Planet, planet_id) + new_moon = Moon.from_dict(request_body, planet, planet_id) + db.session.add(new_moon) + db.session.commit() + return make_response({"message": "moon has been created successfully"}, 201) \ No newline at end of file diff --git a/app/routes/planets_routes.py b/app/routes/planets_routes.py new file mode 100644 index 000000000..0143ea3ac --- /dev/null +++ b/app/routes/planets_routes.py @@ -0,0 +1,163 @@ +from app import db +from flask import Blueprint, jsonify, abort, make_response, request +from app.models.planet import Planet +from app.models.moon import Moon + + +planets_bp = Blueprint("planets", __name__, url_prefix = "/planets") + +# ~~~~~~ Validation Checkers ~~~~~ +def validate_model(cls, model_id): + """ + Checks if planet id is valid and returns error messages for invalid inputs + :params: + - planet_id (int) + :returns: + - planet (object) if valid planet id valid + """ + try: + model_id = int(model_id) + except: + # handling invalid planet id type + abort(make_response({"message":f"{cls.__name__} {model_id} invalid"}, 400)) + # return planet data if id in db + model = cls.query.get(model_id) + # handle nonexistant planet id + if not model: + abort(make_response({"message":f"{cls.__name__} {model_id} not found"}, 404)) + return model + + +def process_kwargs(queries): + """ + Separate kwargs from HTTP request into separate dicts based on SQLAlchemy query method + :params: + - queries (dict) + :returns: + - attrs (dict): planet class attributes kwargs for filter_by + ** name, description, mass + - orderby (dict): method kwargs for order_by + ** sort_mass, sort_name + - sels (dict): selected number of results for limit + """ + planet_attrs = Planet.get_all_attrs() + order_methods = ["sort", "desc"] + attrs = {} + orderby = {} + sels = {} + for kwarg in queries: + if kwarg in planet_attrs: + attrs[kwarg] = queries[kwarg] + elif kwarg in order_methods: + orderby[kwarg] = queries[kwarg] + elif kwarg == "limit": + sels[kwarg] = queries[kwarg] + else: + abort(make_response( + {"message" : f"{kwarg} is an invalid query"}, 400 + )) + return attrs, orderby, sels + + +# ~~~~~~ Planet Routes ~~~~~ +@planets_bp.route("",methods= ["GET"]) +def display_all_planets(): + # collect query & parse kwargs + planet_query = Planet.query + attrs, orderby, sels = process_kwargs(request.args.to_dict()) + if attrs: + # filter by attribute kwargs e.g name=Earth + planet_query = planet_query.filter_by(**attrs) + if "sort" in orderby: + # sort by given attribute e.g.sort=mass + clause = getattr(Planet, orderby["sort"]) + if "desc" in orderby: + # sort in descending order e.g.desc=True + planet_query = planet_query.order_by(clause.desc()) + else: + # default is asc=True + planet_query = planet_query.order_by(clause.asc()) + if sels: + # limit selection of planets to view + planet_query = planet_query.limit(**sels) + # perform query + planets = planet_query.all() + # fill http response + response_planets = [] + for planet in planets: + response_planets.append(planet.to_dict()) + return jsonify(response_planets) + + +# ~~~~~~ Single planet endpoint ~~~~~~ +@planets_bp.route("/",methods=["GET"]) +def display_planet(planet_id): + valid_planet = validate_model(Planet, planet_id) + return valid_planet.to_dict() + + +@planets_bp.route("", methods=["POST"]) +def create_planet(): + request_body = request.get_json() + attribute_requirements = ["name", "description", "mass"] + for req in attribute_requirements: + if req not in request_body: + abort(make_response({ + "message" : f"Failed to create a planet because {req} missing" + }, 400)) + new_planet = Planet.from_dict(request_body) + db.session.add(new_planet) + db.session.commit() + return make_response({"message":"planet has been created successfully"}, 201) + + +@planets_bp.route("/", methods=["PUT"]) +def update_planet(planet_id): + request_body = request.get_json() + planet = validate_model(Planet, planet_id) + planet.name = request_body["name"] if "name" in request_body else planet.name + planet.description = request_body["description"] if "description" in request_body else planet.description + planet.mass = request_body["mass"] if "mass" in request_body else planet.mass + db.session.commit() + return make_response( + {"message": f"Planet #{planet_id} successfully updated"}, 200 + ) + + +@planets_bp.route("/", methods=["DELETE"]) +def delete_planet(planet_id): + planet = validate_model(Planet, planet_id) + db.session.delete(planet) + db.session.commit() + return make_response( + {"message": f"planet #{planet_id} has been deleted successfully"}, 200 + ) + + +@planets_bp.route("//moons", methods=["POST"]) +def create_moon(planet_id): + planet = validate_model(Planet, planet_id) + request_body = request.get_json() + required_attributes = Moon.get_all_attrs() + # check for all required post attributes in request body + for attr in required_attributes: + if attr not in request_body: + abort(make_response(jsonify({ + "message":f"{attr} must be included to add a moon" + }), 400)) + new_moon = Moon.from_dict(request_body, planet, planet_id) + db.session.add(new_moon) + db.session.commit() + return make_response({ + "message": f"Moon {new_moon.name} for Planet {planet.name} successfully created" + }, 201) + + +#nested routes GET `/planets//moons` +@planets_bp.route("//moons", methods=["GET"]) +def read_moons(planet_id): + planet = validate_model(Planet, planet_id) + moons_response = [] + for moon in planet.moons: + moons_response.append(moon.to_dict()) + return jsonify(moons_response) diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/2e9f4c3f0c72_redoing_migrations_to_debug_errors.py b/migrations/versions/2e9f4c3f0c72_redoing_migrations_to_debug_errors.py new file mode 100644 index 000000000..1526c7daa --- /dev/null +++ b/migrations/versions/2e9f4c3f0c72_redoing_migrations_to_debug_errors.py @@ -0,0 +1,45 @@ +"""Redoing migrations to debug errors + +Revision ID: 2e9f4c3f0c72 +Revises: +Create Date: 2023-01-06 12:22:34.301088 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '2e9f4c3f0c72' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('planets', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('name', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('mass', sa.Float(), nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.create_table('moons', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('name', sa.String(), nullable=False), + sa.Column('size', sa.Float(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('discovery_date', sa.DateTime(), nullable=False), + sa.Column('planet_id', sa.Integer(), nullable=True), + sa.ForeignKeyConstraint(['planet_id'], ['planets.id'], ), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('moons') + op.drop_table('planets') + # ### end Alembic commands ### diff --git a/planets.csv b/planets.csv new file mode 100644 index 000000000..ad6c2ef2c --- /dev/null +++ b/planets.csv @@ -0,0 +1,8 @@ +1 Neptune thick, windy 1.0239999999999999e+26 +2 Earth rocky, terrestrial, full of life 5.972e+24 +3 Mars dusty, cold desert 6.39e+23 +6 Mercury small, solid & covered with craters 3.285e+23 +7 Venus Bright and solid surface with dome-like volcanoes, rifts, and mountains 4.867e+24 +8 Jupiter Cold, windy clouds of ammonia and water 1.89813e+27 +9 Saturn Massive ball made mostly of hydrogen and helium 5.683e+26 +10 Uranus Hot dense fluid of 'icy' materials - water, methane, and ammonia 8.681e+25 diff --git a/requirements.txt b/requirements.txt index fba2b3e38..3e19aa0b1 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,18 +1,25 @@ alembic==1.5.4 +attrs==22.2.0 autopep8==1.5.5 blinker==1.4 certifi==2020.12.5 chardet==4.0.0 click==7.1.2 +coverage==7.0.3 Flask==1.1.2 Flask-Migrate==2.6.0 Flask-SQLAlchemy==2.4.4 +gunicorn==20.1.0 idna==2.10 +iniconfig==1.1.1 itsdangerous==1.1.0 Jinja2==2.11.3 Mako==1.1.4 MarkupSafe==1.1.1 +packaging==22.0 +pluggy==1.0.0 psycopg2-binary==2.9.4 +py==1.11.0 pycodestyle==2.6.0 pytest==7.1.1 pytest-cov==2.12.1 @@ -23,5 +30,6 @@ requests==2.25.1 six==1.15.0 SQLAlchemy==1.3.23 toml==0.10.2 +tomli==2.0.1 urllib3==1.26.4 Werkzeug==1.0.1 diff --git a/tests/__init__.py b/tests/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/tests/conftest.py b/tests/conftest.py new file mode 100644 index 000000000..63d98d39c --- /dev/null +++ b/tests/conftest.py @@ -0,0 +1,39 @@ +import pytest +from app import create_app, db +from flask.signals import request_finished +from app.models.planet import Planet + +@pytest.fixture +def app(): + app = create_app(test_config=True) + + @request_finished.connect_via(app) + def expire_session(sender, response, **extra): + db.session.remove() + + with app.app_context(): + db.create_all() + yield app + + with app.app_context(): + db.drop_all() + + +@pytest.fixture +def client(app): + return app.test_client() + +@pytest.fixture +def two_saved_planets(app): + earth = Planet(name="Earth", \ + description="rocky, terrestrial, full of life", mass=5.972e24) + mars = Planet(name="Mars", description="dusty, cold desert", \ + mass=6.39e23) + planets = [earth, mars] + db.session.add_all(planets) + db.session.commit() + + for planet in planets: + db.session.refresh(planet, ["id"]) + + return planets \ No newline at end of file diff --git a/tests/test_models.py b/tests/test_models.py new file mode 100644 index 000000000..34098d271 --- /dev/null +++ b/tests/test_models.py @@ -0,0 +1,62 @@ +from app.models.planet import Planet +import pytest + + +def test_from_dict_with_valid_input(): + test_data = { + "name" : "Neptune", + "description" : "thick, windy", + "mass" : 1.024e26 + } + result = Planet.from_dict(test_data) + + assert result.name == "Neptune" + assert result.description == "thick, windy" + assert result.mass == 1.024e26 + + +def test_from_dict_without_given_name(): + test_data = {"description" : "thick, windy", + "mass" : 1.024e26} + + with pytest.raises(KeyError, match="name"): + Planet.from_dict(test_data) + + +def test_from_dict_without_given_mass(): + test_data = {"description" : "thick, windy", + "name":"Neptune"} + + with pytest.raises(KeyError, match="mass"): + Planet.from_dict(test_data) + +def test_from_dict_without_given_description(): + test_data = { + "name" : "Neptune", + "mass" : 1.024e26 + } + + with pytest.raises(KeyError, match="description"): + Planet.from_dict(test_data) + + +def test_from_dict_with_extra_input(): + test_data = { + "name" : "Neptune", + "description" : "thick, windy", + "mass" : 1.024e26, + "extra1" : "extra info", + "extra2" : "more extra info" + } + + result = Planet.from_dict(test_data) + + assert result.name == "Neptune" + assert result.description == "thick, windy" + assert result.mass == 1.024e26 + +def test_get_by_planet_id_with_to_dict_method_returns_dict(client, two_saved_planets): + response = client.get("planets/1") + response_body = response.get_json() + + assert type(response_body) == dict \ No newline at end of file diff --git a/tests/test_routes.py b/tests/test_routes.py new file mode 100644 index 000000000..930820f2f --- /dev/null +++ b/tests/test_routes.py @@ -0,0 +1,199 @@ +from werkzeug.exceptions import HTTPException +from app.routes.planets_routes import validate_model +from app.models.planet import Planet +import pytest + +#Tests on GET +def test_get_all_planets_with_empty_db_returns_empty_list(client): + response = client.get("/planets") + + assert response.status_code == 200 + assert response.get_json() == [] + +def test_get_one_planet(client, two_saved_planets): + response = client.get("/planets/1") + response_body = response.get_json() + + assert response.status_code == 200 + assert response_body == { + "id" : 1, + "name": "Earth", + "description": "rocky, terrestrial, full of life", + "mass": 5.972e24 + } + +def test_get_planet_by_id_with_empty_db_returns_404(client): + response = client.get("/planets/1") + + assert response.status_code == 404 + assert response.get_json() == {"message" : "Planet 1 not found"} + +def test_get_planet_by_invalid_id_returns_400(client, two_saved_planets): + response = client.get("/planets/earth") + + assert response.status_code == 400 + assert response.get_json() == {"message":"Planet earth invalid"} + +def test_get_planet_by_valid_data_returns_data_and_200(client, two_saved_planets): + response = client.get("/planets") + response_body = response.get_json() + + assert response.status_code == 200 + assert response_body == [ + {"name": "Earth", + "description": "rocky, terrestrial, full of life", + "mass": 5.972e24, + "id": 1}, + {"name": "Mars", + "description": "dusty, cold desert", + "mass": 6.39e23, + "id": 2} + ] + +def test_get_mass_desc_and_limit_1_returns_data_and_200(client, two_saved_planets): + response = client.get("/planets?sort=mass&desc=True&limit=1") + response_body = response.get_json() + + assert response.status_code == 200 + assert response_body == [{ + "name": "Earth", + "description": "rocky, terrestrial, full of life", + "mass": 5.972e24, + "id": 1 + }] + +def test_get_name_desc_and_limit_1_returns_data_and_200(client, two_saved_planets): + response = client.get("/planets?sort=name&desc=True&limit=1") + response_body = response.get_json() + + assert response.status_code == 200 + assert response_body == [{ + "name": "Mars", + "description": "dusty, cold desert", + "mass": 6.39e23, + "id": 2 + }] + +def test_get_by_invalid_query_returns_error_message_and_400(client, two_saved_planets): + response = client.get("/planets?hamster=True") + response_body = response.get_json() + + assert response.status_code == 400 + assert response_body == {"message": "hamster is an invalid query"} + +#Tests on Post +def test_create_one_planet(client): + response = client.post("/planets", json = { + "name": "Neptune", + "description": "thick, windy", + "mass":1.024e26 + }) + response_body = response.get_json() + + assert response.status_code == 201 + assert response_body == {"message":"planet has been created successfully"} + +def test_create_one_planet_missing_mass_return_400(client): + response = client.post("/planets", json = { + "name": "Neptune", + "description": "thick, windy" + }) + response_body = response.get_json() + + assert response.status_code == 400 + assert response_body == {"message" : \ + "Failed to create a planet because mass missing"} + +#Tests on Put +def test_update_planet_successfully(client, two_saved_planets): + test_data = {"name" : "earth", + "description" : "terrestrial, full of life", + "mass" : 5.97e24} + response = client.put("planets/1", json=test_data) + + assert response.status_code == 200 + assert response.get_json() == {"message": "Planet #1 successfully updated"} + +def test_update_planet_with_extra_keys(client, two_saved_planets): + test_data = {"name" : "earth", + "description" : "terrestrial, full of life", + "mass" : 5.97e24, + "moon": "Moon"} + + response = client.put("planets/1", json=test_data) + response_body = response.get_json() + + assert response.status_code == 200 + assert response_body == {"message": "Planet #1 successfully updated"} + + +def test_update_planet_missing_record(client, two_saved_planets): + test_data = { + "name": "Neptune", + "description": "thick, windy", + "mass":1.024e26 + } + + response = client.put("planets/3", json=test_data) + response_body = response.get_json() + + assert response.status_code == 404 + assert response_body == {"message": "Planet 3 not found"} + + +def test_update_planet_invalid_id(client, two_saved_planets): + test_data = { + "name": "Neptune", + "description": "thick, windy", + "mass":1.024e26 + } + + response = client.put("planets/cat", json=test_data) + response_body = response.get_json() + + assert response.status_code == 400 + assert response_body == {"message": "Planet cat invalid"} + +#Tests on Delete +def test_delete_planet_1_with_json_request_body_returns_200(client, two_saved_planets): + response = client.delete("/planets/1", json={ + "name": "Earth", + "description": "rocky, terrestrial, full of life", + "mass": 5.972e24, + "id": 1 + }) + response_body = response.get_json() + + assert response.status_code == 200 + assert response_body == {"message": "planet #1 has been deleted successfully"} + +def test_delete_planet_missing_record(client, two_saved_planets): + response = client.delete("planets/3") + response_body = response.get_json() + + assert response.status_code == 404 + assert response_body == {"message": "Planet 3 not found"} + +def test_delete_planet_invalid_id(client, two_saved_planets): + response = client.delete("planets/cat") + response_body = response.get_json() + + assert response.status_code == 400 + assert response_body == {"message": "Planet cat invalid"} + +#Tests on valid_model(cls, model_id) +def test_validate_model(two_saved_planets): + result_planet = validate_model(Planet, 1) + + assert result_planet.id == 1 + assert result_planet.name == "Earth" + assert result_planet.description == "rocky, terrestrial, full of life" + assert result_planet.mass == 5.972e24 + +def test_validate_model_missing_record(two_saved_planets): + with pytest.raises(HTTPException): + result_planet = validate_model(Planet, 3) + +def test_validate_model_invalid_id(two_saved_planets): + with pytest.raises(HTTPException): + result_planet = validate_model(Planet, "cat") \ No newline at end of file