Revert making icons optional, scaffold them in the public dir instead

Since the icons are now in the public dir, the plugin does not need to copy them.

Author: siphomateke

README.md

@@ -16,13 +16,14 @@ It makes some assumptions about your project setup.
 I hope to be able to scaffold an app so that identifying the below in unnecessary.
 
 ```
+|- public/
+  |- icons/
+    |- Icons for your extension. Should include a 16, 19, 38, 48, 128 px square image
 |- src/
    |- assets/
       |- Static assets in use in your app, like logo.png
    |- content_scripts
       |- content-script.js
-   |- icons/
-      |- Icons for your extension. Should include a 16, 19, 38, 48, 128 px square image
    |- options/ (asked during project generation)
       |- App.vue
       |- options.html
@@ -102,13 +103,11 @@ module.exports = {
   - options
   - contentScripts
   - standalone
-  - icons
 
   ```js
   components: {
     background: true,
-    contentScripts: true,
-    icons: true
+    contentScripts: true
   }
   ```
 

generator/index.js

@@ -96,10 +96,6 @@ module.exports = (api, _options) => {
     api.render('./template/content-script', { ...options })
   }
 
-  if (options.components.icons) {
-    api.render('./template/icons', { name, ...options })
-  }
-
   api.onCreateComplete(() => {
     const gitignore = fs.readFileSync(api.resolve('./.gitignore'), 'utf8')
     fs.writeFileSync(api.resolve('./.gitignore'), gitignore + gitignoreSnippet)

generator/template/icons/src/icons/128.png renamed to generator/template/base-app/public/icons/128.png

@@ -65,13 +65,7 @@ module.exports = (api, options) => {
       }
     }
 
-    const toCopy = []
-
-    if (pluginOptions.components.icons) {
-      toCopy.push({ from: './src/icons', to: 'icons/[name].[ext]', ignore: ['icon.xcf'] })
-    }
-
-    toCopy.push({
+    webpackConfig.plugins.push(new CopyWebpackPlugin({
       from: './src/manifest.json',
       to: 'manifest.json',
       transform: (content) => {
@@ -108,9 +102,7 @@ module.exports = (api, options) => {
           }
         })
       }
-    })
-
-    webpackConfig.plugins.push(new CopyWebpackPlugin(toCopy))
+    }))
 
     if (isProduction) {
       webpackConfig.plugins.push(new ZipPlugin({

generator/template/icons/src/icons/16.png renamed to generator/template/base-app/public/icons/16.png

@@ -2,7 +2,7 @@ module.exports = [
   {
     name: 'components',
     type: 'checkbox',
-    default: ['popup', 'background', 'icons'],
+    default: ['popup', 'background'],
     message: 'Which browser extension components do you wish to generate?',
     choices: [
       {
@@ -36,12 +36,6 @@ module.exports = [
       //   name: 'Dev Tools Tab',
       //   value: 'devTools',
       //   short: 'dev tools'
-      },
-      {
-        name: 'Icons',
-        value: 'icons',
-        short: 'icons',
-        checked: true
       }
     ],
     filter: async (input) => {