Make icons optional

In case the user wants to put their icons in a custom location or
already wants to use their own method of copying them.
For example, the user may put their icons in the public folder which
already has a copying system in place.

Author: siphomateke

generator/index.js

@@ -96,6 +96,10 @@ module.exports = (api, _options) => {
     api.render('./template/content-script', { ...options })
   }
 
+  if (options.components.icons) {
+    api.render('./template/icons', { name, ...options })
+  }
+
   api.onCreateComplete(() => {
     const gitignore = fs.readFileSync(api.resolve('./.gitignore'), 'utf8')
     fs.writeFileSync(api.resolve('./.gitignore'), gitignore + gitignoreSnippet)

…ator/template/base-app/src/icons/128.png …nerator/template/icons/src/icons/128.pnggenerator/template/base-app/src/icons/128.png renamed to generator/template/icons/src/icons/128.png generator/template/base-app/src/icons/128.png renamed to generator/template/icons/src/icons/128.png

@@ -61,42 +61,47 @@ module.exports = (api, options) => {
       }
     }
 
-    webpackConfig.plugins.push(new CopyWebpackPlugin([
-      { from: './src/icons', to: 'icons/[name].[ext]', ignore: ['icon.xcf'] },
-      {
-        from: './src/manifest.json',
-        to: 'manifest.json',
-        transform: (content) => {
-          return new Promise((resolve, reject) => {
-            const jsonContent = JSON.parse(content)
-            jsonContent.version = version
-
-            if (isProduction) {
-              return resolve(JSON.stringify(jsonContent, null, 2))
-            }
-
-            jsonContent.content_security_policy = "script-src 'self' 'unsafe-eval'; object-src 'self'"
-
-            try {
-              fs.statSync(keyFile)
-
-              return exec(`openssl rsa -in ${keyFile} -pubout -outform DER | openssl base64 -A`, (error, stdout) => {
-                if (error) {
-                  // node couldn't execute the command
-                  reject(error)
-                }
-
-                jsonContent.key = stdout
-                resolve(JSON.stringify(jsonContent, null, 2))
-              })
-            } catch (error) {
-              logger.warn('No key.pem file found. This is fine for dev, however you may have problems publishing without one')
+    const toCopy = []
+
+    if (options.components.icons) {
+      toCopy.push({ from: './src/icons', to: 'icons/[name].[ext]', ignore: ['icon.xcf'] })
+    }
+
+    toCopy.push({
+      from: './src/manifest.json',
+      to: 'manifest.json',
+      transform: (content) => {
+        return new Promise((resolve, reject) => {
+          const jsonContent = JSON.parse(content)
+          jsonContent.version = version
+
+          if (isProduction) {
+            return resolve(JSON.stringify(jsonContent, null, 2))
+          }
+
+          jsonContent.content_security_policy = "script-src 'self' 'unsafe-eval'; object-src 'self'"
+
+          try {
+            fs.statSync(keyFile)
+
+            return exec(`openssl rsa -in ${keyFile} -pubout -outform DER | openssl base64 -A`, (error, stdout) => {
+              if (error) {
+                // node couldn't execute the command
+                reject(error)
+              }
+
+              jsonContent.key = stdout
               resolve(JSON.stringify(jsonContent, null, 2))
-            }
-          })
-        }
+            })
+          } catch (error) {
+            logger.warn('No key.pem file found. This is fine for dev, however you may have problems publishing without one')
+            resolve(JSON.stringify(jsonContent, null, 2))
+          }
+        })
       }
-    ]))
+    })
+
+    webpackConfig.plugins.push(new CopyWebpackPlugin(toCopy))
 
     if (isProduction) {
       webpackConfig.plugins.push(new ZipPlugin({

…rator/template/base-app/src/icons/16.png generator/template/icons/src/icons/16.pnggenerator/template/base-app/src/icons/16.png renamed to generator/template/icons/src/icons/16.png generator/template/base-app/src/icons/16.png renamed to generator/template/icons/src/icons/16.png

@@ -2,7 +2,7 @@ module.exports = [
   {
     name: 'components',
     type: 'checkbox',
-    defaults: ['popup', 'background'],
+    defaults: ['popup', 'background', 'icons'],
     message: 'Which browser extension components do you wish to generate?',
     choices: [
       {
@@ -36,6 +36,12 @@ module.exports = [
       //   name: 'Dev Tools Tab',
       //   value: 'devTools',
       //   short: 'dev tools'
+      },
+      {
+        name: 'Icons',
+        value: 'icons',
+        short: 'icons',
+        checked: true
       }
     ],
     filter: async (input) => {