From 8b4f4eb446fdb41a0264d3af48025184e82e22d4 Mon Sep 17 00:00:00 2001 From: Dan Kurin Date: Wed, 13 Nov 2024 11:12:24 -0500 Subject: [PATCH 1/4] Update types.ts --- lib/types.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/types.ts b/lib/types.ts index b519129..3b4ee0d 100644 --- a/lib/types.ts +++ b/lib/types.ts @@ -63,6 +63,7 @@ export type CreateCertificateOptions = { domains: string[] validityDays: 90 | 365 strictDomains: boolean + replacementForCertificate?: string } export type KeyPair = { From 25e0b2806ee2b6a7eb9aca23f2fa8774f559d108 Mon Sep 17 00:00:00 2001 From: Dan Kurin Date: Wed, 13 Nov 2024 11:16:22 -0500 Subject: [PATCH 2/4] Update zerossl.ts --- lib/zerossl.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/zerossl.ts b/lib/zerossl.ts index 67687d8..03dc2bb 100644 --- a/lib/zerossl.ts +++ b/lib/zerossl.ts @@ -51,12 +51,14 @@ export class ZeroSSL { const qs = this.queryString({ access_key: this.options.accessKey }) const url = `${this.options.apiUrl}/certificates?${qs}` - const postFn = superagent.post(url) + let postFn = superagent.post(url) .type('form') .field('certificate_domains', options.domains.join(',')) .field('certificate_csr', options.csr) .field('certificate_validity_days', options.validityDays) .field('strict_domains', options.strictDomains) + + if (options.replacementForCertificate) postFn = postFn.field('replacement_for_certificate', options.replacementForCertificate as string) const result = await this.performRequest(postFn) return result.body as CertificateRecord From 8825c905f40e006ea440bee7c26852b929765af8 Mon Sep 17 00:00:00 2001 From: Dan Kurin Date: Wed, 13 Nov 2024 11:23:40 -0500 Subject: [PATCH 3/4] Build --- dist/lib/types.d.ts | 1 + dist/lib/zerossl.js | 2 ++ 2 files changed, 3 insertions(+) diff --git a/dist/lib/types.d.ts b/dist/lib/types.d.ts index f782bda..52bf5f3 100644 --- a/dist/lib/types.d.ts +++ b/dist/lib/types.d.ts @@ -53,6 +53,7 @@ export type CreateCertificateOptions = { domains: string[]; validityDays: 90 | 365; strictDomains: boolean; + replacementForCertificate?: string; }; export type KeyPair = { publicKey: string; diff --git a/dist/lib/zerossl.js b/dist/lib/zerossl.js index 7c6e282..b8aa0e3 100644 --- a/dist/lib/zerossl.js +++ b/dist/lib/zerossl.js @@ -98,6 +98,8 @@ var ZeroSSL = (function () { .field('certificate_csr', options.csr) .field('certificate_validity_days', options.validityDays) .field('strict_domains', options.strictDomains); + if (options.replacementForCertificate) + postFn = postFn.field('replacement_for_certificate', options.replacementForCertificate); return [4, this.performRequest(postFn)]; case 1: result = _a.sent(); From a200500b105ffedcc33e550f80a33fee9891a6f3 Mon Sep 17 00:00:00 2001 From: Dan Kurin Date: Thu, 14 Nov 2024 09:02:51 -0500 Subject: [PATCH 4/4] PR feedback --- dist/lib/zerossl.js | 2 +- lib/zerossl.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dist/lib/zerossl.js b/dist/lib/zerossl.js index b8aa0e3..ea6e4a6 100644 --- a/dist/lib/zerossl.js +++ b/dist/lib/zerossl.js @@ -99,7 +99,7 @@ var ZeroSSL = (function () { .field('certificate_validity_days', options.validityDays) .field('strict_domains', options.strictDomains); if (options.replacementForCertificate) - postFn = postFn.field('replacement_for_certificate', options.replacementForCertificate); + postFn.field('replacement_for_certificate', options.replacementForCertificate); return [4, this.performRequest(postFn)]; case 1: result = _a.sent(); diff --git a/lib/zerossl.ts b/lib/zerossl.ts index 03dc2bb..03a633b 100644 --- a/lib/zerossl.ts +++ b/lib/zerossl.ts @@ -51,14 +51,14 @@ export class ZeroSSL { const qs = this.queryString({ access_key: this.options.accessKey }) const url = `${this.options.apiUrl}/certificates?${qs}` - let postFn = superagent.post(url) + const postFn = superagent.post(url) .type('form') .field('certificate_domains', options.domains.join(',')) .field('certificate_csr', options.csr) .field('certificate_validity_days', options.validityDays) .field('strict_domains', options.strictDomains) - if (options.replacementForCertificate) postFn = postFn.field('replacement_for_certificate', options.replacementForCertificate as string) + if (options.replacementForCertificate) postFn.field('replacement_for_certificate', options.replacementForCertificate as string) const result = await this.performRequest(postFn) return result.body as CertificateRecord