Skip to content

Commit 654f882

Browse files
bokelleyclaude
andauthored
feat: export FormatId, PackageRequest, PushNotificationConfig, and PriceGuidance from stable API (#68)
Add missing types to stable.py public API: - FormatId: Format identifier type (agent_url + id) - PackageRequest: Request structure for creating packages - PushNotificationConfig: Webhook push notification configuration - PriceGuidance: Pricing guidance for auction-based options (floor, percentiles) These types are commonly used in AdCP workflows and should be part of the stable public API to avoid users importing from internal generated modules. Changes: - Add types to adcp.types.stable imports and __all__ - Add types to adcp.__init__.py imports and __all__ - Group PriceGuidance with other pricing types - Add new "Configuration types" section for PushNotificationConfig All types are properly exported from both stable.py and main package. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent ee8017a commit 654f882

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

src/adcp/__init__.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@
132132
Error,
133133
FlatRatePricingOption,
134134
Format,
135+
FormatId,
135136
GetMediaBuyDeliveryRequest,
136137
GetMediaBuyDeliveryResponse,
137138
GetProductsRequest,
@@ -147,14 +148,17 @@
147148
MediaBuy,
148149
MediaBuyStatus,
149150
Package,
151+
PackageRequest,
150152
PackageStatus,
151153
PreviewCreativeRequest,
152154
PreviewCreativeResponse,
155+
PriceGuidance,
153156
PricingModel,
154157
Product,
155158
Property,
156159
ProvidePerformanceFeedbackRequest,
157160
ProvidePerformanceFeedbackResponse,
161+
PushNotificationConfig,
158162
SyncCreativesRequest,
159163
SyncCreativesResponse,
160164
UpdateMediaBuyRequest,
@@ -214,6 +218,7 @@
214218
"ProvidePerformanceFeedbackResponse",
215219
"Error",
216220
"Format",
221+
"FormatId",
217222
"Product",
218223
"Property",
219224
# Core domain types (from stable API)
@@ -222,23 +227,27 @@
222227
"CreativeManifest",
223228
"MediaBuy",
224229
"Package",
230+
"PackageRequest",
225231
# Package type aliases
226232
"CreatedPackageReference",
227233
# Status enums (for control flow)
228234
"CreativeStatus",
229235
"MediaBuyStatus",
230236
"PackageStatus",
231237
"PricingModel",
232-
# Pricing options (all 9 types)
238+
# Pricing-related types
233239
"CpcPricingOption",
234240
"CpcvPricingOption",
235241
"CpmAuctionPricingOption",
236242
"CpmFixedRatePricingOption",
237243
"CppPricingOption",
238244
"CpvPricingOption",
239245
"FlatRatePricingOption",
246+
"PriceGuidance",
240247
"VcpmAuctionPricingOption",
241248
"VcpmFixedRatePricingOption",
249+
# Configuration types
250+
"PushNotificationConfig",
242251
# Adagents validation
243252
"AuthorizationContext",
244253
"fetch_adagents",

src/adcp/types/stable.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
Error,
4949
FlatRatePricingOption,
5050
Format,
51+
FormatId,
5152
GetMediaBuyDeliveryRequest,
5253
GetMediaBuyDeliveryResponse,
5354
GetProductsRequest,
@@ -66,14 +67,17 @@
6667
MarkdownAsset,
6768
MediaBuy,
6869
MediaBuyStatus,
70+
PackageRequest,
6971
PackageStatus,
7072
PreviewCreativeRequest,
7173
PreviewCreativeResponse,
74+
PriceGuidance,
7275
PricingModel,
7376
Product,
7477
Property,
7578
ProvidePerformanceFeedbackRequest,
7679
ProvidePerformanceFeedbackResponse,
80+
PushNotificationConfig,
7781
SyncCreativesRequest,
7882
SyncCreativesResponse,
7983
TasksGetRequest,
@@ -143,18 +147,21 @@
143147
"CreativeManifest",
144148
"Error",
145149
"Format",
150+
"FormatId",
146151
"MediaBuy",
147152
"Package",
153+
"PackageRequest",
148154
"Product",
149155
"Property",
150-
# Pricing options
156+
# Pricing-related types
151157
"CpcPricingOption",
152158
"CpcvPricingOption",
153159
"CpmAuctionPricingOption",
154160
"CpmFixedRatePricingOption",
155161
"CppPricingOption",
156162
"CpvPricingOption",
157163
"FlatRatePricingOption",
164+
"PriceGuidance",
158165
"VcpmAuctionPricingOption",
159166
"VcpmFixedRatePricingOption",
160167
# Status enums
@@ -164,6 +171,8 @@
164171
"PricingModel",
165172
"TaskStatus",
166173
"TaskType",
174+
# Configuration types
175+
"PushNotificationConfig",
167176
# Assets
168177
"AudioAsset",
169178
"CssAsset",

0 commit comments

Comments
 (0)