From 819ee874dfd7456df515998778cef81d7e7a48f4 Mon Sep 17 00:00:00 2001 From: moritzraho Date: Wed, 23 Jul 2025 12:49:38 +0200 Subject: [PATCH 1/4] use oauth_s2s tokens on smoke tests --- .github/workflows/app-smoke-test.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/app-smoke-test.yml b/.github/workflows/app-smoke-test.yml index 2de21d3..fab0774 100644 --- a/.github/workflows/app-smoke-test.yml +++ b/.github/workflows/app-smoke-test.yml @@ -40,12 +40,14 @@ jobs: uses: adobe/aio-apps-action@3.3.0 with: os: ${{ matrix.os }} - command: auth - CLIENTID: ${{ secrets.JWT_CLIENTID }} - CLIENTSECRET: ${{ secrets.JWT_CLIENT_SECRET }} - TECHNICALACCOUNTID: ${{ secrets.JWT_TECH_ACC_ID }} - IMSORGID: ${{ secrets.JWT_ORG_ID }} - KEY: ${{ secrets.JWT_PRIVATE_KEY }} + command: oauth_sts + CLIENTID: ${{ secrets.IMS_CLIENTID }} + CLIENTSECRET: ${{ secrets.OMS_CLIENT_SECRET }} + IMSORGID: ${{ secrets.IMS_ORG_ID }} + # we are using dummy values as they are not needed to generate oauth_s2s tokens + # see https://github.com/adobe/aio-lib-ims-oauth/issues/114 + TECHNICALACCOUNTID: dummy_id + TECHNICALACCOUNTEMAIL: dummy_email - id: create name: create app with no extensions run: | From 9fe68cbdb21a899e14e2d22499306db2f20f9d4d Mon Sep 17 00:00:00 2001 From: moritzraho Date: Wed, 23 Jul 2025 12:52:34 +0200 Subject: [PATCH 2/4] missing scopes --- .github/workflows/app-smoke-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/app-smoke-test.yml b/.github/workflows/app-smoke-test.yml index fab0774..67b823b 100644 --- a/.github/workflows/app-smoke-test.yml +++ b/.github/workflows/app-smoke-test.yml @@ -44,6 +44,7 @@ jobs: CLIENTID: ${{ secrets.IMS_CLIENTID }} CLIENTSECRET: ${{ secrets.OMS_CLIENT_SECRET }} IMSORGID: ${{ secrets.IMS_ORG_ID }} + SCOPES: ${{ secrets.IMS_SCOPES }} # we are using dummy values as they are not needed to generate oauth_s2s tokens # see https://github.com/adobe/aio-lib-ims-oauth/issues/114 TECHNICALACCOUNTID: dummy_id From bbef16437b28cb896af24ea4a00be400dbea8ae8 Mon Sep 17 00:00:00 2001 From: moritzraho Date: Wed, 23 Jul 2025 12:53:41 +0200 Subject: [PATCH 3/4] typo --- .github/workflows/app-smoke-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/app-smoke-test.yml b/.github/workflows/app-smoke-test.yml index 67b823b..db078a5 100644 --- a/.github/workflows/app-smoke-test.yml +++ b/.github/workflows/app-smoke-test.yml @@ -42,7 +42,7 @@ jobs: os: ${{ matrix.os }} command: oauth_sts CLIENTID: ${{ secrets.IMS_CLIENTID }} - CLIENTSECRET: ${{ secrets.OMS_CLIENT_SECRET }} + CLIENTSECRET: ${{ secrets.IMS_CLIENT_SECRET }} IMSORGID: ${{ secrets.IMS_ORG_ID }} SCOPES: ${{ secrets.IMS_SCOPES }} # we are using dummy values as they are not needed to generate oauth_s2s tokens From d516200ca1e82f0645cecd2b72de4a07dbbf3c82 Mon Sep 17 00:00:00 2001 From: moritzraho Date: Wed, 23 Jul 2025 12:56:33 +0200 Subject: [PATCH 4/4] typo 2 --- .github/workflows/app-smoke-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/app-smoke-test.yml b/.github/workflows/app-smoke-test.yml index db078a5..1b4902e 100644 --- a/.github/workflows/app-smoke-test.yml +++ b/.github/workflows/app-smoke-test.yml @@ -41,7 +41,7 @@ jobs: with: os: ${{ matrix.os }} command: oauth_sts - CLIENTID: ${{ secrets.IMS_CLIENTID }} + CLIENTID: ${{ secrets.IMS_CLIENT_ID }} CLIENTSECRET: ${{ secrets.IMS_CLIENT_SECRET }} IMSORGID: ${{ secrets.IMS_ORG_ID }} SCOPES: ${{ secrets.IMS_SCOPES }}